Some help with icomplete

Some help with icomplete

[Rahul Martim Juliato]

Hello there!


I've been strugling with something I can see as possible but am sure it
is not obvious (at least not for me).


On plain emacs if I use `icomplete-vertical-mode' with
`icomplete-in-buffer' set to t, I get a "company/corfu like" completion
"in buffer" feature.


Thing is, the list always starts on the next line (that is ok) but on
the first column. So it is very strange to M-TAB with the cursor on
column 50 and get a list on column 0. If I were using plain
`icomplete-mode' (no vertical), it would complete horizontally from the
place my cursor is at the moment.

Can anyone elucidate me on how to make it work the way I'd like to?


Some screenshots to illustrate it:

With vertical mode on the beginning of the line

https://0x0.st/X-Ue.png

With vertical mode on some advanced column

http://0x0.st/X-U2.png

Without vertical mode on the beginning of the line

http://0x0.st/X-U_.png

Without vertical mode on some advanced column

http://0x0.st/X-UL.png


Thanks!

Rahul M. Juliato

Re: Some help with icomplete

[Zhengyi Fu]

Rahul Martim Juliato <rahuljuliato@gmail.com> writes:

> Thing is, the list always starts on the next line (that is ok) but on
> the first column. So it is very strange to M-TAB with the cursor on
> column 50 and get a list on column 0. If I were using plain
> `icomplete-mode' (no vertical), it would complete horizontally from the
> place my cursor is at the moment.
>
> Can anyone elucidate me on how to make it work the way I'd like to?

If you compile Emacs from source, you can try this patch:

Index: emacs/lisp/icomplete.el
===================================================================
--- emacs.orig/lisp/icomplete.el
+++ emacs/lisp/icomplete.el
@@ -913,6 +913,16 @@ icomplete--render-vertical
                  ((> (length scroll-above) (length scroll-below)) nsections)
                  (t (min (ceiling nsections 2) (length scroll-above))))
            lines))
+    (when icomplete--in-region-buffer
+      (let ((column
+	     (with-current-buffer icomplete--in-region-buffer
+	       (save-excursion
+		 (goto-char (car completion-in-region--data))
+		 (current-column)))))
+	(dolist (l lines)
+	  (add-text-properties
+           0 1 `(display ,(concat (make-string column ?\s) (substring l 0 1)))
+           l))))
     ;; At long last, render final string return value.  This may still
     ;; kick out lines at the end.
     (concat " \n"

-- 
Zhengyi Fu

Re: Some help with icomplete

[Eli Zaretskii]

> From: Zhengyi Fu <i@fuzy.me>
> Cc: help-gnu-emacs@gnu.org
> Date: Tue, 16 Apr 2024 15:46:56 +0800
> 
> Rahul Martim Juliato <rahuljuliato@gmail.com> writes:
> 
> > Thing is, the list always starts on the next line (that is ok) but on
> > the first column. So it is very strange to M-TAB with the cursor on
> > column 50 and get a list on column 0. If I were using plain
> > `icomplete-mode' (no vertical), it would complete horizontally from the
> > place my cursor is at the moment.
> >
> > Can anyone elucidate me on how to make it work the way I'd like to?
> 
> If you compile Emacs from source, you can try this patch:
> 
> Index: emacs/lisp/icomplete.el
> ===================================================================
> --- emacs.orig/lisp/icomplete.el
> +++ emacs/lisp/icomplete.el

Since icomplete.el is not preloaded, applying this patch does not
require rebuilding Emacs from sources.  It only requires
byte-compiling icomplete.el after patching it, and perhaps restarting
Emacs.

Re: Some help with icomplete

[Rahul Martim Juliato]

Zhengyi Fu <i@fuzy.me> writes:

> Rahul Martim Juliato <rahuljuliato@gmail.com> writes:
>
>> Thing is, the list always starts on the next line (that is ok) but on
>> the first column. So it is very strange to M-TAB with the cursor on
>> column 50 and get a list on column 0. If I were using plain
>> `icomplete-mode' (no vertical), it would complete horizontally from the
>> place my cursor is at the moment.
>>
>> Can anyone elucidate me on how to make it work the way I'd like to?
>
> If you compile Emacs from source, you can try this patch:
>
> Index: emacs/lisp/icomplete.el
> ===================================================================
> --- emacs.orig/lisp/icomplete.el
> +++ emacs/lisp/icomplete.el
> @@ -913,6 +913,16 @@ icomplete--render-vertical
>                   ((> (length scroll-above) (length scroll-below)) nsections)
>                   (t (min (ceiling nsections 2) (length scroll-above))))
>             lines))
> +    (when icomplete--in-region-buffer
> +      (let ((column
> +	     (with-current-buffer icomplete--in-region-buffer
> +	       (save-excursion
> +		 (goto-char (car completion-in-region--data))
> +		 (current-column)))))
> +	(dolist (l lines)
> +	  (add-text-properties
> +           0 1 `(display ,(concat (make-string column ?\s) (substring l 0 1)))
> +           l))))
>      ;; At long last, render final string return value.  This may still
>      ;; kick out lines at the end.
>      (concat " \n"

Thank you Zhengyi!

This worked like a charm!

Is this already suggested as a patch to Emacs core?

Even if optional, I believe Emacs would greatly benefit from it.


Rahul M. Juliato

Re: Some help with icomplete

[Zhengyi Fu]

Rahul Martim Juliato <rahuljuliato@gmail.com> writes:
>
> Is this already suggested as a patch to Emacs core?
>
> Even if optional, I believe Emacs would greatly benefit from it.
>

No.  I didn't submit it to Emacs core.

I don't use icomplete-vertical-mode anymore.

This patch was just a quick hack and I don't think it's the best way to
implement this feature.

-- 
Zhengyi Fu