all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Importing "quoted" strings in `org-babel-import-elisp-from-file'
Date: Sat, 04 May 2024 08:03:27 +0000	[thread overview]
Message-ID: <87plu2dmwg.fsf@localhost> (raw)
In-Reply-To: <v14pi5$jrb$1@ciao.gmane.io>

Max Nikulin <manikulin@gmail.com> writes:

>>> (org-babel-read "\"1\\\\\" 2 \\\\\"3\"" t)
>>> "1\\"
>> 
>> Fixed, on main.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2028bb15c
>
> I have no idea if "other\n\"string\"\nlines" may be passed 
> `org-babel-read', but it is not discarded by the current regexp:
>
> "^[[:space:]]*\"\\(.*\\)\"[[:space:]]*$"

I do not see why we should limit things to single-line strings.

> Is there a reason why it is necessary to call `read' twice on the same 
> content? From my point of view, result of first call may be returned.

Yes, it can. 

> Does `read' have other role than unescaping backslash-protected 
> characters? Likely it can be done by `replace-regexp-in-string', see the 
> attachment. ...

> +(defconst org-babel--quoted-string-regexp
> ...

1. read is faster
2. read is less maintenance - we can rely upon robust implementation
   provided by Emacs itself instead of doing something custom, with
   potential bugs.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-05-04  8:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28 13:15 [BUG] ob-shell: results missing leading quotes Matt
2024-04-29 11:58 ` Ihor Radchenko
2024-05-01 10:48   ` Max Nikulin
2024-05-01 12:19     ` Importing "quoted" strings in `org-babel-import-elisp-from-file' (was: [BUG] ob-shell: results missing leading quotes) Ihor Radchenko
2024-05-02 17:56       ` Importing "quoted" strings in `org-babel-import-elisp-from-file' Max Nikulin
2024-05-03 12:06         ` Ihor Radchenko
2024-05-04  7:53           ` Max Nikulin
2024-05-04  8:03             ` Ihor Radchenko [this message]
2024-05-04 11:17               ` Max Nikulin
2024-05-04 11:51                 ` Ihor Radchenko
2024-05-04 14:55                   ` Max Nikulin
2024-05-04 19:34                     ` Ihor Radchenko
2024-05-04 15:58                   ` Max Nikulin
2024-05-04 19:35                     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plu2dmwg.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.