From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: 70134@debbugs.gnu.org
Subject: bug#70134: [PATCH] Show all date options when adding Gnus scores interactively
Date: Fri, 10 May 2024 14:27:58 -0700 [thread overview]
Message-ID: <87plttpdb5.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87edbovjvj.fsf@kubajecminek.cz>
Jakub Ječmínek via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> Apologies for the formatting, I’m writing this reply from my phone.
>
>> And sure enough, the modification of the string is the point -- it's a
>> cache! From gnus-sum.el:
>>
>> ; Since this is called not only to sort the top-level threads, but
>> ; also in recursive sorts to order the articles within a thread, each
>> ; article will be processed many times. Thus it speeds things up
>> ; quite a bit to use gnus-date-get-time, which caches the time value.
>> (defun gnus-thread-latest-date (thread)
>> "Return the highest article date in THREAD."
>> (apply #'max
>> (mapcar (lambda (header) (float-time
>> (gnus-date-get-time
>> (mail-header-date header))))
>> (flatten-tree thread))))
>>
>> Can we strip properties around the call, maybe?
>
> I don’t think there’s need to do that. The change that I proposed in
> the patch should remove the unintended side effect (and thus fix the
> bug pointed by Alex) while keeping the caching behaviour intact
> (‘gnus-thread-latest-date’ code above will work as expected).
Okay, thanks. I won't mess with it, then.
next prev parent reply other threads:[~2024-05-10 21:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 21:44 bug#70134: [PATCH] Show all date options when adding Gnus scores interactively Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 7:58 ` Eli Zaretskii
2024-04-22 3:33 ` Eric Abrahamsen
2024-04-24 22:52 ` Richard Stallman
2024-04-24 23:08 ` Alex Bochannek
2024-05-01 19:27 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-07 2:53 ` Alex Bochannek
2024-05-09 19:15 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 23:59 ` Eric Abrahamsen
2024-05-10 20:04 ` Eric Abrahamsen
2024-05-10 20:38 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-10 21:27 ` Eric Abrahamsen [this message]
2024-05-14 2:00 ` Alex Bochannek
2024-05-14 14:52 ` Eric Abrahamsen
2024-05-14 18:43 ` Alex Bochannek
2024-05-14 19:57 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 14:15 ` Eric Abrahamsen
2024-05-16 19:40 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 21:34 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 23:30 ` Alex Bochannek
2024-05-23 2:50 ` Eric Abrahamsen
2024-05-26 14:22 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-26 22:09 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 21:23 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 0:16 ` Alex Bochannek
2024-05-30 9:01 ` Andrea Corallo
2024-05-30 16:30 ` Alex Bochannek
2024-08-07 20:22 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plttpdb5.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=70134@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.