From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: URGENT - which-key FSF contributor status Date: Tue, 18 Jun 2024 08:49:47 +0000 Message-ID: <87plsews7o.fsf@posteo.net> References: <87le4r98m9.fsf@jeremybryant.net> <86le4rjv9p.fsf@gnu.org> <87a5l78kc0.fsf@posteo.net> <87msp6o9o4.fsf@jeremybryant.net> <87sexelgnj.fsf@posteo.net> <86wmmqtmkl.fsf@gnu.org> <87wmmqmkh3.fsf@posteo.net> <86a5jmterj.fsf@gnu.org> <87le36kua5.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13862"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 18 10:50:40 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJUY4-0003R4-1s for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Jun 2024 10:50:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJUXL-0000s7-2s; Tue, 18 Jun 2024 04:49:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJUXJ-0000ru-Kc for emacs-devel@gnu.org; Tue, 18 Jun 2024 04:49:53 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJUXH-0005A2-Qb for emacs-devel@gnu.org; Tue, 18 Jun 2024 04:49:53 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 11649240027 for ; Tue, 18 Jun 2024 10:49:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718700589; bh=LX31Rgml/dnFlhKoph40OWvqiZk4DsU7SKiq/Jvr2w8=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=Pp9XmSfQRqsPS98b801PiVZ35R5INm16x/l6MBXnSn/XEWzZat5qaK3/CWeObuNX8 //TM3qL77AT6D+RMwhOpFcb6tZeOwWHIN1Mv940ml+l5L44UXYlfxbONWEJIg7cbjR eVE86d0L+dFTjQSjjK+gRU2+OY/08B++v5mbBqPtyvyzfdh4deMmQpOoVCqyKw6eY+ aI/Frqgzi16Inih0AkAMnot8EMfWAT7vkF+SnLWfwxX4cUw0MzZqAsiJgfmzMtUv0A NoJ3ZeJy8wg4IfxVJvJberPs8gYq040CKAP4OOVJ4iYaDfj+m3mjvSCMCKF/bNoWRQ dmc0c0JZnNO2g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W3L6N2Dfqz9rxN; Tue, 18 Jun 2024 10:49:48 +0200 (CEST) In-Reply-To: <87le36kua5.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 15 Jun 2024 17:09:06 +0000") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320232 Archived-At: Philip Kaludercic writes: > Eli Zaretskii writes: > >>> From: Philip Kaludercic >>> Cc: jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org >>> Date: Sat, 15 Jun 2024 12:58:00 +0000 >>> >>> Eli Zaretskii writes: >>> >>> >> From: Philip Kaludercic >>> >> Cc: Eli Zaretskii , Justin Burkett , >>> >> emacs-devel@gnu.org >>> >> Date: Sat, 15 Jun 2024 09:05:52 +0000 >>> >> >>> >> We have found out that Bar has completed the CA. That means we can >>> >> proceed with adding which-key, perhaps even by Emacs 30 (Eli?)? >>> > >>> > Yes. If you do this _very_ quickly. >>> >>> I have pushed a working branch under "feature/which-key-in-core". >>> Please take a look to see if I missed something obvious, and if it seems >>> fine I can merge it into master right away. >> >> Thanks. A couple of comments: >> >> The :version tags of the defcustoms and deffaces will need to change. > > I can change the current tags to :package-version and also add :version > "30.1" tags. This has been done. >> Some faces use attributes such as underline or bold without testing >> for their availability first and without offering any fallbacks if >> they aren't. Is it okay to have those displayed using the default >> face? > > My guess is that this is just decoration, but someone who actually uses > which-key should comment on that. Specifically it appears to involve > the > > - which-key-special-key-face > - which-key-highlighted-command-face I think that it should be OK for 'which-key-special-key-face' to use :bold, because it is accompanied by :inverse-video that carries most of the visual effect. As for 'which-key-highlighted-command-face', I have removed the :underline and instead let it inherit from 'highlight'. I hope nobody objects to that. By default it doesn't make any difference, as it only affects people who have customised 'which-key-highlighted-command-list'. IMO we could merge the branch into master. > faces. -- Philip Kaludercic on peregrine