Re: URGENT - which-key FSF contributor status

[Philip Kaludercic <philipk@posteo.net>]

Philip Kaludercic <philipk@posteo.net> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Philip Kaludercic <philipk@posteo.net>
>>> Cc: jb@jeremybryant.net,  justin@burkett.cc,  emacs-devel@gnu.org
>>> Date: Sat, 15 Jun 2024 12:58:00 +0000
>>> 
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>> 
>>> >> From: Philip Kaludercic <philipk@posteo.net>
>>> >> Cc: Eli Zaretskii <eliz@gnu.org>,  Justin Burkett <justin@burkett.cc>,
>>> >>  emacs-devel@gnu.org
>>> >> Date: Sat, 15 Jun 2024 09:05:52 +0000
>>> >> 
>>> >> We have found out that Bar has completed the CA.  That means we can
>>> >> proceed with adding which-key, perhaps even by Emacs 30 (Eli?)?
>>> >
>>> > Yes.  If you do this _very_ quickly.
>>> 
>>> I have pushed a working branch under "feature/which-key-in-core".
>>> Please take a look to see if I missed something obvious, and if it seems
>>> fine I can merge it into master right away.
>>
>> Thanks.  A couple of comments:
>>
>> The :version tags of the defcustoms and deffaces will need to change.
>
> I can change the current tags to :package-version and also add :version
> "30.1" tags.

This has been done.

>> Some faces use attributes such as underline or bold without testing
>> for their availability first and without offering any fallbacks if
>> they aren't.  Is it okay to have those displayed using the default
>> face?
>
> My guess is that this is just decoration, but someone who actually uses
> which-key should comment on that.  Specifically it appears to involve
> the
>
> - which-key-special-key-face
> - which-key-highlighted-command-face

I think that it should be OK for 'which-key-special-key-face' to use
:bold, because it is accompanied by :inverse-video that carries most of
the visual effect.

As for 'which-key-highlighted-command-face', I have removed the
:underline and instead let it inherit from 'highlight'.  I hope nobody
objects to that.  By default it doesn't make any difference, as it only
affects people who have customised 'which-key-highlighted-command-list'.

IMO we could merge the branch into master.

> faces.

-- 
	Philip Kaludercic on peregrine