From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#64055: Implementation of modifying VC change comments for Git Date: Tue, 22 Oct 2024 16:30:30 +0800 Message-ID: <87plnsfsk9.fsf@melete.silentflame.com> References: <874j59wym3.fsf@melete.silentflame.com> <868qukl73k.fsf@gnu.org> <87bjzfuzaq.fsf@melete.silentflame.com> <5514e870-3766-4070-838a-e92495c1da55@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12472"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan.J.Smith@outlook.com, Eli Zaretskii , 64055@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 22 10:32:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3AJP-00036Q-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Oct 2024 10:32:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3AJA-00086t-7n; Tue, 22 Oct 2024 04:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3AIp-000862-AL for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2024 04:31:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3AIg-0000q3-IU for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2024 04:31:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=AT5GZ03skOKsAvrQuG+oIOPK5BcPhkCttz+/Ot2nzvI=; b=Ig4kUswfrJYj/seBYiZF//WMR6xU8LHjUgGIqs0XLJq4wO43tyDpXNZXkgXsqLUmKgIrjDL2Fi0pAq64eyGAw5DWxcDV3iTVeaXDmXUiPh84X/OmSNbHVzEcf4KsbrJCWnsMRzHuiAwYm643N4Bl2cuASDk5BgU9Gv+ju9qhh7OW9RKP0LLsfPsDPpFVMq7PRCRMHjWvNjJ4TVVKcxm5AGcFgSZXZoy3uTSki5eDzak7foJaDNeie0oAn30RejOw4xQE/3QvRZJXAiSO11+zaiV0jtEgDIFkg5ABC4Wgyjrb5Ci6LJUTuZYVUgaThNtIl6Cz929FnG6YTMpRvaa0VQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3AJ8-0005n5-3C for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2024 04:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2024 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172958586922172 (code B ref 64055); Tue, 22 Oct 2024 08:32:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 22 Oct 2024 08:31:09 +0000 Original-Received: from localhost ([127.0.0.1]:54564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3AIH-0005lY-G9 for submit@debbugs.gnu.org; Tue, 22 Oct 2024 04:31:09 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:54150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3AIG-0005lK-55 for 64055@debbugs.gnu.org; Tue, 22 Oct 2024 04:31:08 -0400 DKIM-Signature: a=rsa-sha256; b=OBqvfsuaXA4ajVKdtr8uXQdmkqQFJ9TR+iTIwILjqWQXU0HTqQUCS48k6ItDmpNjI0uVIum0jOu/bb23KyP2bzbmzyOY5+0j8mtvdZXx80bpYCeLitrhQ/rtpK7eQnlmJzbk1LIjF90P4j+A0hstiHwM66E50udcWHe8+mdwNFCabQDjJ3eMiXwWba93+8tLdHt0r2Y1CYk87U6xBm/wzmmT0NMbgBzAO4ngAaTXZ0PQoQDOcJk8/lkovWXKrr9hmcGVmm8j31yqUlDdoKsdW3mD2ZJ2FKKEWiaIzYahyoGZ/hOOdWFfIXRYhBLmatxcKDpTNsWodqChbyrslF+npw==; s=purelymail2; d=spwhitton.name; v=1; bh=/cixLIR2WC379LmGsQrVNzH2059DqjQN2s4Ju5vlheg=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=QTIn4uuLwl6VCdcjKL9pDOoRTv8GbPHp0k0tXzlwmHENiI3aNPj4hAFUxd1WZZcH0LnJ/2Xd00KFn5drHRxZQsSSa42x8xygpScq68N9B+HnOmKewJ6WVc5+xDa2FrTmU0CoRLQY7AVIU+4dIdaquaCBMqbBKexYW1xfwzL56mOhbKtjeZqHt5dzjO23s5rv3N5nYtIsuPo/kPX/tvzs8hvT7B+pO8c4jJGF1lW4G4C5ok0skr6sXn9XGjUzxzTUZ62iCVEAgiFjLuQvrrOhe6EAtvjITAMiafz4Lb3KAcxHp4BddXWyvBUBjQrJ9GlYmOhB6XPV3uUe237tnZWxzQ==; s=purelymail2; d=purelymail.com; v=1; bh=/cixLIR2WC379LmGsQrVNzH2059DqjQN2s4Ju5vlheg=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 64055@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1427495828; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 22 Oct 2024 08:30:34 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 530277EACFD; Tue, 22 Oct 2024 16:30:30 +0800 (CST) In-Reply-To: <5514e870-3766-4070-838a-e92495c1da55@yandex.ru> (Dmitry Gutov's message of "Mon, 21 Oct 2024 21:08:37 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294095 Archived-At: Hello, On Mon 21 Oct 2024 at 09:08pm +01, Dmitry Gutov wrote: > On 20/10/2024 08:19, Sean Whitton wrote: >> + (nothing-staged >> + (zerop >> + (vc-git-command nil t nil "diff" "--cached" "--quiet")))) > > Testing it a little more, this seems insufficient because rebase aborts on > non-staged changes too. This seems to cover both cases: > > (no-changes > (zerop > (vc-git-command nil t nil "diff" "HEAD" "--quiet")))) Thanks. I forgot that --autostash covers that case already. -- Sean Whitton