From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.bugs Subject: bug#75018: 30.0.93; Dired icon missing in tool-bar Date: Sun, 22 Dec 2024 13:52:22 -0600 Message-ID: <87plljh4w9.fsf@pub.pink> References: <87o714r2ky.fsf@pub.pink> <86bjx46wvs.fsf@gnu.org> <6bfb0822-f2e9-48d5-bcf3-0012fc432782@app.fastmail.com> <86msgn6582.fsf@gnu.org> <871pxzijsx.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.1; emacs 31.0.50 Cc: 75018@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 22 20:53:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPS0w-000ABx-WD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Dec 2024 20:53:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPS0e-0000IM-IR; Sun, 22 Dec 2024 14:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPS0c-0000HZ-VH for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 14:53:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPS0c-00008y-Lv for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 14:53:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Orj4weXmIJK9xM98xe8ntP3rEBQDe1Jjg7ERqj4kYSQ=; b=I37marWFhS7SV4HV14uQ6/piHHxnK2pZRHjpicDljYQa+vcUa350Hl+3aeCmDAFq7/okxWzPGGFd51jad99y6V3Hetg/E71XIDLLuyZZieuONrlwgCsDiqM4uQ+0uGKRrnDgxbVw/MIFhSzTgPcp0WBfcIFcm0qeTT9E5NgwNsPcOkBE0onlmd/uhKsqmBhcjBm8vzwJ7GRqjR9dMAcBzTcNPGSb5bT/xfg0Ge9fbZ0KKLFFAw+wl7BPqvzgxjfRwiVkNMJJYKrXcaIzy0h1d7sqef3ZQcfzmwYWchOFgMBKRFZwoXFZrkTbqgFxB0WFfvNEAD1KwJP47eymCdzB9g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPS0c-0006PZ-HK for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 14:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2024 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75018 X-GNU-PR-Package: emacs Original-Received: via spool by 75018-submit@debbugs.gnu.org id=B75018.173489715224577 (code B ref 75018); Sun, 22 Dec 2024 19:53:02 +0000 Original-Received: (at 75018) by debbugs.gnu.org; 22 Dec 2024 19:52:32 +0000 Original-Received: from localhost ([127.0.0.1]:52011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPS07-0006OK-Bw for submit@debbugs.gnu.org; Sun, 22 Dec 2024 14:52:31 -0500 Original-Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]:45743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPS04-0006O4-Nb for 75018@debbugs.gnu.org; Sun, 22 Dec 2024 14:52:29 -0500 Original-Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id A349C11400A9; Sun, 22 Dec 2024 14:52:23 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Sun, 22 Dec 2024 14:52:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1734897143; x=1734983543; bh=Orj4weXmIJK9xM98xe8ntP3rEBQDe1Jjg7ERqj4kYSQ=; b= ICf+lZbm9uaNYPDDnqqKpxQC1rmmy1Ax9lJoo/xO49FWH7RZfySrRUzznMCAU21U PxmWGWnROz6Ro6/Er74PS9FG+soqdPYDfMis3Vgm7deHduNjOog+Q6yd8VP6KT3o FVLUwerloPQ/wb1qgmtSxPFV1+Eq8srPH8G+bqeov7294JPpt08f6Vg0120i5lDk aQKIta1ZNoBcOME3vhIlSZFcy5KOZHyJQd8Vg1/204hdj0sphDlAmc0QPm4ukEXb anj/E0ns2uwV7bUvPByw4+fqML3ihLYa+MIlFMQ1Feak5z4RdBn/mnhgBZzBTmK4 Salgg/xm2vs2Q7T3ytA//w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1734897143; x= 1734983543; bh=Orj4weXmIJK9xM98xe8ntP3rEBQDe1Jjg7ERqj4kYSQ=; b=t MTFJt9346dfd+v3c6KO/wUBGrHaFVxvbGHuOQjuXF0zptnWifL8BWNq6XNhLrYHA jiyCH+A88H6uWuzeuk4pSWPs6BOZu9vE1gjKBFgrZuoeYDB+RQawpzt6BGPNOyel FL5++QhPrOu3S46Lv1zGlAp/PjpxHeuaYA6VJrIlMtW544BuiFycVTuzgY+zWf1I pNjRjTZBeweKy4HJyODaRQQzqzJCS6Ayu0Ov+zlsnQbAcIWVdOdIjFzIby+6ms8u pzI1a66HEh+6sbhUAllcZfdO82wH0MaFRn6YiLPpOHc3xMKVJ/TTnwpNPWLkuPJs DBE47wPOh7Hf1z5ZJQFcg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddtkedguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttder jeenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtf frrghtthgvrhhnpeeiueeggfetfffgieegkedvkeekvedvgeevfeehveegheevveehudfh iedviefhheenucffohhmrghinhepfhgvughorhgrphhrohhjvggtthdrohhrghenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdr phhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtth hopeejhedtudekseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihii sehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 22 Dec 2024 14:52:23 -0500 (EST) In-Reply-To: <871pxzijsx.fsf@pub.pink> (john muhl's message of "Sun, 22 Dec 2024 13:45:02 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297623 Archived-At: Confirmation it=E2=80=99s not just me: https://discussion.fedoraproject.org/t/the-gdb-toolbar-icons-are-displayed-= incorrectly-in-emacs-on-fedora-41-with-gnome/136650 john muhl writes: > Eli Zaretskii writes: > >>> Date: Sun, 22 Dec 2024 09:32:23 -0600 >>> From: "john muhl" >>> Cc: 75018@debbugs.gnu.org >>>=20 >>> On Sun, Dec 22, 2024, at 12:43 AM, Eli Zaretskii wrote: >>> >> From: john muhl >>> >> Date: Sat, 21 Dec 2024 18:19:57 -0600 >>> >>=20 >>> >> The usual Dired icon is missing and instead shows up as a couple >>> >> of tiny triangles in the normal state and as a very generic file >>> >> icon on hover. Happens on emacs-30 and master and X11 and PGTK >>> >> builds. Lucid and Motif builds are unaffected. >>> > >>> > Where do the tool-bar icons come from in that build? They are not >>> > from the Emacs's etc/images/ directory, AFAICT. >>>=20 >>> They are the stock GTK icons. On this system they are located in >>> /usr/share/icons/. The option x-gtk-stock-map is responsible for >>> the mapping between Emacs' etc/images/* and the system's >>> icons. The attached patch fixes it here. >> >> Can you explain the rationale for the patch and how it solves the >> problem? > > Honestly I don=E2=80=99t understand how x-gtk-stock-map does its thing. I > was just trying to get an icon to appear. > > My first idea was to remove mapping for etc/images/diropen hoping > it would fall back on the included image but that didn=E2=80=99t work. In > fact setting x-g-s-m to nil (PROBLEMS suggests this should cause > Emacs=E2=80=99 included icons to be used) causes all the icons to fail to > be found and end up looking the same way as the broken Dired icon. > >>> > Can you post the Dired icon file from where your build takes them? >>>=20 >>> Unfortunately I can't find those particular icons among the ~7000 >>> icons in the /usr/share/icons/ directory but they're probably in >>> there somewhere. >> >> If you run Emacs under GDB with a breakpoint in lookup_image, you >> should see all the tool-bar icons being loaded during startup. You >> can use the following GDB commands for the breakpoint, to see when the >> icon you are interested in gets loaded: >> >> pp spec >> >> This should show you the full absolute file name of the icon file >> Emacs is loading. >> >> The command "pp" is defined in src/.gdbinit, so if you don't start GDB >> from that directory, you will need to say >> >> (gdb) source /path/to/emacs/src/.gdbinit >> >> before running Emacs, to be able to use this useful command. > > With the breakpoint in place I see: > > (image :type xpm > :file "/home/jm/tmp/emacs-30/etc/images/diropen.xpm" > :scale default) > > All the others icons similarly claim to be loaded from an XMP file > in the Emacs source directory. Of course those XMP files look > nothing like those that actually appear in the tool-bar. The icons > that are actually used are all somewhere under > /usr/share/icons/Adwaita/symbolic/. > >>> > Also, is this problem new in the last pretest, or did previous >>> > pretests behave the same? >>>=20 >>> I tried 30.0.90 and 29.4 and they too are using the incorrect >>> icons. I suspect upgrading to Fedora 41 is what causes the >>> issue. >> >> Yes, that's usually the first suspect in such cases. >> >> Thanks. > > Actually now that I=E2=80=99m paying attention I see missing icons all > over the place. This message-mode buffer is missing icons for > =E2=80=9CFile this draft message and exit=E2=80=9D and =E2=80=9CPreview= =E2=80=9D. Info mode is > missing =E2=80=9CGoto previous node=E2=80=9D, =E2=80=9CGoto next node=E2= =80=9D and =E2=80=9CGo up the info > tree=E2=80=9D. A VC-log buffer is missing another handful...