all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: Stefan Kangas <stefankangas@gmail.com>,
	Konstantin Kharlamov <Hi-Angel@yandex.ru>,
	Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Adding git-commit highlight mode?
Date: Fri, 03 Jan 2025 14:08:44 +0100	[thread overview]
Message-ID: <87pll459k3.fsf@bernoul.li> (raw)
In-Reply-To: <CADwFkmkzy4O7V-+p=1k6K5scBvUa4VfeZ0MkDet-o4rmFGU=AQ@mail.gmail.com>

> I'm copying in Jonas Bernoulli, in case he has any comments.

I was under the impression that log-edit.el is Emacs's git-commit.el.
I haven't looked at it in a long time, so maybe I don't remember this
correctly, but doesn't that cover about the same ground?  Modulo some
quality of life improvements and bells and whistles maybe. 

One idea from git-commit.el that you might want to adapt in your
alternative is to *not* center the package around a single major-mode.
git-commit.el instead adds to find-file-hook a function, which checks if
the visited file is one of those files used by Git to have to user write
a commit message.  If so, it enables the *minor*-mode git-commit-mode
(which adds some additional font-lock and key bindings) but first *some*
major-mode.  The major-mode can be different for different repositories,
which is quite useful, considering that different projects follow vastly
different commit message conventions.

     Cheers,
     Jonas



  parent reply	other threads:[~2025-01-03 13:08 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 18:30 Adding git-commit highlight mode? Konstantin Kharlamov
2025-01-02 19:01 ` Eli Zaretskii
2025-01-02 19:07   ` Konstantin Kharlamov
2025-01-02 20:10     ` Stefan Kangas
2025-01-02 21:01       ` Eli Zaretskii
2025-01-02 21:38         ` Stefan Kangas
2025-01-03  5:26           ` Jim Porter
2025-01-02 21:40       ` Konstantin Kharlamov
2025-01-03  5:29         ` Jim Porter
2025-01-03 13:08       ` Jonas Bernoulli [this message]
2025-01-02 20:11     ` Eli Zaretskii
2025-01-02 21:19       ` Arsen Arsenović
2025-01-02 21:53         ` Stefan Kangas
2025-01-02 22:27           ` Arsen Arsenović
2025-01-03 21:02           ` Sean Whitton
2025-01-04  7:17             ` Eli Zaretskii
2025-01-04  9:52               ` Sean Whitton
2025-01-03  6:45         ` Eli Zaretskii
2025-01-02 19:17 ` Jim Porter
2025-01-02 19:19   ` Konstantin Kharlamov
2025-01-02 20:17   ` Eli Zaretskii
2025-01-03 21:14   ` Björn Bidar
2025-01-05 14:39     ` Philip Kaludercic
2025-01-05 22:48       ` Konstantin Kharlamov
     [not found]   ` <87r05jbnw2.fsf@>
2025-01-03 22:52     ` Konstantin Kharlamov
2025-01-04  1:22       ` Björn Bidar
     [not found]       ` <87v7uv9xub.fsf@>
2025-01-04  1:45         ` Konstantin Kharlamov
2025-01-05  0:46           ` Björn Bidar
     [not found]           ` <871pxiulxz.fsf@>
2025-01-05  3:55             ` Konstantin Kharlamov
2025-01-04 12:50         ` Jonas Bernoulli
2025-01-04 17:20           ` Jonas Bernoulli
2025-01-05  0:32           ` Björn Bidar
2025-01-05 18:47           ` Jim Porter
2025-01-05  0:42 ` Björn Bidar
     [not found] ` <875xmuum48.fsf@>
2025-01-05  3:49   ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pll459k3.fsf@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=Hi-Angel@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.