From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: compile.el Date: Tue, 23 Aug 2005 22:33:48 +0300 Organization: JURTA Message-ID: <87oe7oe9mz.fsf@jurta.org> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1124826524 16080 80.91.229.2 (23 Aug 2005 19:48:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 Aug 2005 19:48:44 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 23 21:48:35 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E7eiv-0000C5-Ar for ged-emacs-devel@m.gmane.org; Tue, 23 Aug 2005 21:46:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E7emi-0005dq-DW for ged-emacs-devel@m.gmane.org; Tue, 23 Aug 2005 15:50:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E7em8-0005Vw-LG for emacs-devel@gnu.org; Tue, 23 Aug 2005 15:49:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E7ehZ-0003yo-NN for emacs-devel@gnu.org; Tue, 23 Aug 2005 15:45:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E7ehW-0003pN-Bs for emacs-devel@gnu.org; Tue, 23 Aug 2005 15:44:50 -0400 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E7eYU-0007zH-No; Tue, 23 Aug 2005 15:35:30 -0400 Original-Received: from mail.neti.ee (80-235-39-20-dsl.mus.estpak.ee [80.235.39.20]) by Relayhost2.neti.ee (Postfix) with ESMTP id CDC8A1F7B; Tue, 23 Aug 2005 22:34:28 +0300 (EEST) Original-To: rms@gnu.org In-Reply-To: (Richard M. Stallman's message of "Mon, 22 Aug 2005 15:35:44 -0400") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42364 Archived-At: > My patch to compile.el has a bug; here's a revised patch. It has another bug: visiting a saved compilation/grep file fails with the error message: Symbol's value as variable is void: comint-file-name-prefix This is trivial to fix - just restore `(boundp 'comint-file-name-prefix)' that was there before the patch. But it has another more severe bug: visiting a file in a compilation subdirectory extracted from the line `make: Entering directory ...' doesn't work anymore. Since the issue of visiting saved compilation/grep logs is currently under consideration, I want also to point out that changing the file's default directory by the -*- line is not a good thing. It is potentially dangerous when an unsuspecting user assumes that the default directory is the same as the directory where the file is saved, but actually it changes to the directory where compilation was started. I think `-*- default-directory: "..." -*-' in the first line should be changed to `-*- compilation-directory: "..." -*-'. Currently this doesn't work with `compilation-directory' in the first line, but it is easy to fix compile.el to take into account this case. -- Juri Linkov http://www.jurta.org/emacs/