From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.devel Subject: Re: Space after inline comment char Date: Tue, 18 Apr 2006 10:09:20 -0700 Organization: Newt Software Message-ID: <87odyykdz3.fsf@olgas.newt.com> References: <32708.1145055187@olgas.newt.com> <8764lbv8ia.fsf-monnier+emacs@gnu.org> <87zmilu3hn.fsf-monnier+emacs@gnu.org> <87ejzwsvxs.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1145380257 28355 80.91.229.2 (18 Apr 2006 17:10:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 18 Apr 2006 17:10:57 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 18 19:10:56 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FVtiu-0005bU-DH for ged-emacs-devel@m.gmane.org; Tue, 18 Apr 2006 19:10:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FVtit-0001fu-PY for ged-emacs-devel@m.gmane.org; Tue, 18 Apr 2006 13:10:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FVtiI-0001Pr-H0 for emacs-devel@gnu.org; Tue, 18 Apr 2006 13:10:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FVtiG-0001Nh-5v for emacs-devel@gnu.org; Tue, 18 Apr 2006 13:10:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FVtiF-0001NZ-Uo for emacs-devel@gnu.org; Tue, 18 Apr 2006 13:10:04 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FVtjA-0003bA-UL for emacs-devel@gnu.org; Tue, 18 Apr 2006 13:11:01 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FVti1-0005QY-Pp for emacs-devel@gnu.org; Tue, 18 Apr 2006 19:09:50 +0200 Original-Received: from adsl-69-236-173-190.dsl.pltn13.pacbell.net ([69.236.173.190]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Apr 2006 19:09:49 +0200 Original-Received: from wohler by adsl-69-236-173-190.dsl.pltn13.pacbell.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Apr 2006 19:09:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 30 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: adsl-69-236-173-190.dsl.pltn13.pacbell.net User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:RPzhUpDoIIlVhciQqfppXo6OSYE= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53018 Archived-At: Stefan Monnier writes: >>>>> That's easy: change comment-start from ";" to "; ". >>>> Then commenting at the beginning of a line will not work correctly >>>> anymore. >>> What makes you think so? >>> AFAIK, the only side-effect it'll have is that there won't be a difference >>> between a comment-padding set to 1 or to 0. > >> Try >> emacs -Q -eval '(progn (setq comment-start "; ") (insert "foo\n") (comment-region (point-max) (point-min)))' > >> That will result in >> ; foo >> whereas it should be >> ;; foo > > Good point. I believe the patch below has fixed it, Yes, it has. Thanks! Still, if most people insert a space after running M-;--as the sources seem to indicate--it seems like including the space in the default for comment-start is good usability. Plus it will help keep the look of the comments in Emacs consistent, which is a good thing. -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane.