From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: Small bug in PC-expand-many-files. Date: Mon, 17 Jul 2006 13:30:37 +0200 Organization: Epita/LRDE Message-ID: <87odvojwo2.fsf@lrde.org> References: <87bqt7nohb.fsf@lrde.org> <87odwxnmub.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1418184773==" X-Trace: sea.gmane.org 1153135842 19681 80.91.229.2 (17 Jul 2006 11:30:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 17 Jul 2006 11:30:42 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 17 13:30:36 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G2RJ3-0003Kj-6m for ged-emacs-devel@m.gmane.org; Mon, 17 Jul 2006 13:30:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G2RJ2-0000rd-NR for ged-emacs-devel@m.gmane.org; Mon, 17 Jul 2006 07:30:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G2RIr-0000qc-AM for emacs-devel@gnu.org; Mon, 17 Jul 2006 07:30:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G2RIp-0000nv-8o for emacs-devel@gnu.org; Mon, 17 Jul 2006 07:30:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G2RIp-0000nW-3D for emacs-devel@gnu.org; Mon, 17 Jul 2006 07:30:19 -0400 Original-Received: from [62.39.139.2] (helo=kualalumpur.lrde.epita.fr) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1G2RLT-0000VC-CN for emacs-devel@gnu.org; Mon, 17 Jul 2006 07:33:03 -0400 Original-Received: from mahaena.lrde.epita.fr ([192.168.101.66] helo=mahaena.lrde) by kualalumpur.lrde.epita.fr with esmtp (Exim 4.50) id 1G2RIm-0007rP-Jr for emacs-devel@gnu.org; Mon, 17 Jul 2006 13:30:16 +0200 Original-To: emacs-devel@gnu.org Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU/JREXDATg1LV8UCao i1fQpmoP3Nd6AAACa0lEQVQ4jWWUQW7jMAxFqZEPICJzAjXeM6W8dyNqX9ji/a8yn04xnWIEJLD9 LJH85DcJFyJV3erqPty8ExHfBikXSdn0WVezC0hOAQiA2nCsAHOqEnPe4k+puU8zw/t+xquqjRKA 4lHsmQBT8C5pDtBwfwH8VdcHI5+FHtjRxrQRwZsf3hNjZRKAPEzHEdH9mFNSYb5dQK3r8KM6ftNy KikAirDZFWdVkDqbxjGFbAcwbQCxxc8mPRHUGOcCIMgMACV23RfJTch3gC6ofT3qCdG0NyUUPfYF yQrKCIAnuYsgX2qPzW2i9sNrfSOSPPZQiygtCNlCjlpXJV38lIKshF/AZzsAMoArdCKNHfXukPuJ ImbLh+9J2gXwap0QpZ7NjZ7ekdkFcDiqPiLGcHmuvaG/AHgy62s52Lae1ABoA7D6d2kDoAvgbnyD ZutEd6lTHOXfYPHVJDH1K8a1+oyrjoZpAGn1x5pfwPr2E9yjxSpk50/gEyKgD/+BD/KzN3tQ13b8 Cx5loF0AgnZf5IUny9hRHQOYBllHDM+6s3oviZBu77mFjDm621Np3hkjR90wE1BkTYvhdDgDgCmR xWChFfcYAOqMm5NZkVWMur8AL5+oeMQOob2FmY76FiM+PrDDZypwGdqokSlAaQOmGH6mW8KpsOwl 0YOLedjSITr6scNRF8D4PesH33QmLrx8AzjpV/3kkg025w2gfAFYKCLluJAc4Ap+h18oo4S8wzaY klDsBUTiY8EZFkg5Iass75FubC9wd8qa0u9+gRxAsAKEaRAo6iB+vwCMGmdBjvgidQGA1ntMX4CS ZYGV/wADyL80LIX/UAAAAABJRU5ErkJggg== In-Reply-To: <87odwxnmub.fsf@lrde.org> (=?iso-8859-1?Q?Micha=EBl?= Cadilhac's message of "Tue, 13 Jun 2006 16:37:16 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:57170 Archived-At: --===============1418184773== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable michael.cadilhac@lrde.org (Micha=EBl Cadilhac) writes: > michael.cadilhac@lrde.org (Micha=EBl Cadilhac) writes: > >> Recipe: >> In your ~, you have a directory `helloworld' in which there's a file >> called `foobarbaz'. You don't have a directory named `demaille'. >> >> $ emacs -Q >> M-x partial-completion-mode RET >> C-x C-f ~/demaille/akim RET >> (message: Use M-x make-directory RET RET to create the directory and >> its parents) >> >> C-x C-f ~/hell/foo TAB >> (*error*: shell-command: Setting current directory: no such file or >> directory, /home/micha/demaille) >> >> >> This is due to a call to `call-process' within a buffer created after >> the `akim' one, from which it takes its default directory. >> >> I propose the following change, which AFAICT, fixes the bug: AFAICT, this patch hasn't been reviewed. Can anyone review this proposal? TIA! > Index: lisp/ChangeLog > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /sources/emacs/emacs/lisp/ChangeLog,v > retrieving revision 1.9661 > diff -c -r1.9661 ChangeLog > *** lisp/ChangeLog 1 Jun 2006 06:42:07 -0000 1.9661 > --- lisp/ChangeLog 5 Jun 2006 23:51:00 -0000 > *************** > *** 1,3 **** > --- 1,8 ---- > + 2006-06-06 Micha=EBl Cadilhac > +=20 > + * complete.el (PC-expand-many-files): Go to the home directory > + before `shell-command' if the default one is not executable. > +=20 > 2006-06-01 Jan Dj=E4rv > > * term/x-win.el: Change x-menu-bar-start to menu-bar-open. > Index: lisp/complete.el > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /sources/emacs/emacs/lisp/complete.el,v > retrieving revision 1.53 > diff -c -r1.53 complete.el > *** lisp/complete.el 22 May 2006 18:09:40 -0000 1.53 > --- lisp/complete.el 5 Jun 2006 23:51:00 -0000 > *************** > *** 778,783 **** > --- 778,785 ---- > (defun PC-expand-many-files (name) > (with-current-buffer (generate-new-buffer " *Glob Output*") > (erase-buffer) > + (unless (file-executable-p default-directory) > + (setq default-directory "~/")) > (shell-command (concat "echo " name) t) > (goto-char (point-min)) > ;; CSH-style shells were known to output "No match", whereas =2D-=20 | Micha=EBl `Micha' Cadilhac | Si les religions etaient aussi tole= - | | Epita/LRDE Promo 2007 | rantes qu'elles le pretendent, il y = | | http://www.lrde.org/~cadilh_m | a longtemps qu'il n'y en aurait plus = | `-- - JID: micha@amessage.be --' -- Moustic - -= -' --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFEu3TdZYNf4qobZ7kRAhgDAJ43LGvZrtA40OjyZr6QMMgyKntcTwCaAo/E TUs9g8owFoC306IS8r0rgEo= =PMPp -----END PGP SIGNATURE----- --=-=-=-- --===============1418184773== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1418184773==--