From: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org, Noah Friedman <friedman@splode.com>
Subject: Re: sit-for and idle timers
Date: Mon, 14 Aug 2006 15:47:07 -0400 [thread overview]
Message-ID: <87odun6qx0.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1GChzV-0002nz-6d@fencepost.gnu.org> (Richard Stallman's message of "Mon, 14 Aug 2006 15:20:49 -0400")
> Why do these timer functions call sit-for? It is a strange thing for
> a timer to wait. It should reschedule itself instead. What are they
> really trying to do?
It varies from situation to situation. For example, jit-lock uses the
idle timer function jit-lock-stealth-fontify, which calls sit-for.
The goal, in that case, is to wait a certain amount of time between
fontifying chunks.
> I think the solution is to avoid calling timer_start_idle when
> read-event is given a non-nil SECONDS argument. What do people think?
>
> That is definitely not right. Emacs really is idle when it reads an event,
> even if there is a timeout.
>
> So my conclusion is that when read-event is called from an idle timer,
> it should not change the state to idle at the beginning, and it should
> not change the state away from idle at the end.
>
> Does this change fix it?
I already checked in a different change to keyboard.c before your
email came in. But I think your version makes more sense.
next prev parent reply other threads:[~2006-08-14 19:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 19:48 sit-for and idle timers Noah Friedman
2006-08-11 21:00 ` Chong Yidong
2006-08-14 18:34 ` Chong Yidong
2006-08-14 19:20 ` Richard Stallman
2006-08-14 19:47 ` Chong Yidong [this message]
2006-08-14 20:05 ` Chong Yidong
2006-08-15 12:41 ` Richard Stallman
2006-08-15 20:12 ` Chong Yidong
2006-08-16 19:27 ` Richard Stallman
2006-08-16 19:38 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87odun6qx0.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=friedman@splode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.