From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: C-x v v no longer works the way it used to Date: Mon, 15 Oct 2007 07:51:24 +0900 Message-ID: <87odf18g43.fsf@catnip.gol.com> References: <87r6jxctcv.fsf@rho.meyering.net> <87y7e59zs1.fsf@offby1.atm01.sea.blarg.net> Reply-To: Miles Bader NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192402348 9214 80.91.229.12 (14 Oct 2007 22:52:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2007 22:52:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eric Hanchrow Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 15 00:52:18 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IhCJd-0001Z8-1N for ged-emacs-devel@m.gmane.org; Mon, 15 Oct 2007 00:52:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IhCJV-0000nH-Pd for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 18:52:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IhCJ5-0000Y9-UU for emacs-devel@gnu.org; Sun, 14 Oct 2007 18:51:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IhCJ3-0000X4-N0 for emacs-devel@gnu.org; Sun, 14 Oct 2007 18:51:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IhCJ3-0000Wv-GC for emacs-devel@gnu.org; Sun, 14 Oct 2007 18:51:33 -0400 Original-Received: from smtp02.dentaku.gol.com ([203.216.5.72]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IhCIz-0006DC-Mu; Sun, 14 Oct 2007 18:51:30 -0400 Original-Received: from 203-216-97-240.dsl.gol.ne.jp ([203.216.97.240] helo=catnip.gol.com) by smtp02.dentaku.gol.com with esmtpa (Dentaku) id 1IhCIx-0002U2-3r; Mon, 15 Oct 2007 07:51:27 +0900 Original-Received: by catnip.gol.com (Postfix, from userid 1000) id 49A2E2F5D; Mon, 15 Oct 2007 07:51:24 +0900 (JST) System-Type: i686-pc-linux-gnu In-Reply-To: <87y7e59zs1.fsf@offby1.atm01.sea.blarg.net> (Eric Hanchrow's message of "Sun\, 14 Oct 2007 14\:01\:18 -0700") Original-Lines: 37 X-Abuse-Complaints: abuse@gol.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80878 Archived-At: Eric Hanchrow writes: > Jim> if I were visiting a non-version-controlled file and hit C-x > Jim> v v, it would effectively add that single file to the version > Jim> control system. i.e., cvs add, git add, etc. > > Jim> Now, all it does is print "No fileset is available here." > Jim> Is this intentional? > > I assume so. If so, it's arguably wrong. "C-x v v" is "do the right thing for version control", not "commit this file". Even if new behavior _is_ desirable, the error message is very vague and confusing; something like "The file NAME is not under revision control; use to add it" would be much more useful. I think maybe some good guidelines might be: 1) Don't use unusual terms like "fileset" in error messages unless it's impossible to do better. 2) Try to refer to something concrete that the user can associate with the command he gave (one could use a helper function for signalling vc errors that would use alternative phrasing depending on the situation, e.g., "file FOO" for a single file, and "files FOO, BAR, BAZ" for multiple files, etc). 3) Don't use vague phrasing like "not available here". What does "here" refer to -- the machine, the current directory, some internal code state...? What does "not available" mean? It sounds like it could be a temporary error... -Miles -- ((lambda (x) (list x x)) (lambda (x) (list x x)))