From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: isearch for doc-view.el Date: Mon, 05 Nov 2007 14:19:29 +0100 Message-ID: <87ode8omn2.fsf@baldur.tsdh.de> References: <7gk5p448xq.fsf@fencepost.gnu.org> <87wst33g0o.fsf@baldur.tsdh.de> <87pryv3eew.fsf@baldur.tsdh.de> <87k5p3qisa.fsf@baldur.tsdh.de> <87ejfbqdb4.fsf@baldur.tsdh.de> <87y7dhv89p.fsf@jurta.org> <87ejf8kxwg.fsf@baldur.tsdh.de> <87sl3koq9k.fsf_-_@baldur.tsdh.de> <86k5owlv5i.fsf@lola.quinscape.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194268789 23576 80.91.229.12 (5 Nov 2007 13:19:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2007 13:19:49 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 05 14:19:52 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ip1ro-0005UL-Dg for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 14:19:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ip1rd-0006v7-OZ for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 08:19:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ip1rZ-0006uE-Po for emacs-devel@gnu.org; Mon, 05 Nov 2007 08:19:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ip1rY-0006ti-Aa for emacs-devel@gnu.org; Mon, 05 Nov 2007 08:19:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ip1rY-0006tZ-6q for emacs-devel@gnu.org; Mon, 05 Nov 2007 08:19:32 -0500 Original-Received: from out1.smtp.messagingengine.com ([66.111.4.25]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ip1rY-0004Es-1P for emacs-devel@gnu.org; Mon, 05 Nov 2007 08:19:32 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id AC8C9453A5 for ; Mon, 5 Nov 2007 08:19:31 -0500 (EST) Original-Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 05 Nov 2007 08:19:31 -0500 X-Sasl-enc: fOSxfurNcXM5gDJuzYBqdz+zC3e8g7Ay7NW8GVPpmX15 1194268771 Original-Received: from baldur.tsdh.de (dslb-084-063-062-224.pools.arcor-ip.net [84.63.62.224]) by mail.messagingengine.com (Postfix) with ESMTP id D0D6028157 for ; Mon, 5 Nov 2007 08:19:30 -0500 (EST) Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <86k5owlv5i.fsf@lola.quinscape.zz> (David Kastrup's message of "Mon, 05 Nov 2007 13:43:53 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82573 Archived-At: David Kastrup writes: Hi David, >> Index: lisp/doc-view.el >> =================================================================== >> RCS file: /sources/emacs/emacs/lisp/doc-view.el,v >> retrieving revision 1.18 >> diff -u -r1.18 doc-view.el >> --- lisp/doc-view.el 1 Nov 2007 03:53:32 -0000 1.18 >> +++ lisp/doc-view.el 5 Nov 2007 11:41:33 -0000 > > [...] > >> ;; Searching >> - (define-key map (kbd "C-s") 'doc-view-search) >> - (define-key map (kbd "") 'doc-view-search) >> - (define-key map (kbd "C-S-n") 'doc-view-search-next-match) >> - (define-key map (kbd "C-S-p") 'doc-view-search-previous-match) >> + (define-key map (kbd "C-s") 'isearch-forward) >> + (define-key map (kbd "") 'isearch-forward) >> + (define-key map (kbd "C-r") 'isearch-backward) > > Is a definition even necessary? Can't you just inherit the normal > bindings? Indeed, I removed the definitions and it still works as expected. Thanks for the hint. Bye, Tassilo