From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: C-r and C-s in minibuffer should search completion Date: Thu, 17 Apr 2008 02:16:45 +0300 Organization: JURTA Message-ID: <87od89sb4y.fsf@jurta.org> References: <87prtiik0l.fsf@jurta.org> <87iqz969fh.fsf@jurta.org> <87od9181m7.fsf@jurta.org> <87lk440z31.fsf@jurta.org> <87od8xccz6.fsf@jurta.org> <87hceouksk.fsf@jurta.org> <87y77zlqji.fsf@jurta.org> <873aq2czp4.fsf@jurta.org> <871w5j2ca1.fsf@jurta.org> <87r6d6vjg2.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208388222 6287 80.91.229.12 (16 Apr 2008 23:23:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Apr 2008 23:23:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 17 01:24:11 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JmGz5-0006b9-Aq for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2008 01:24:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmGyO-0006t3-Ie for ged-emacs-devel@m.gmane.org; Wed, 16 Apr 2008 19:23:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmGyL-0006s3-2H for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmGyJ-0006rA-Gd for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmGyJ-0006r7-AT for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:23 -0400 Original-Received: from relay01.kiev.sovam.com ([62.64.120.200]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JmGyI-0003Z8-Sd for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:23 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JmGyE-000Gig-JQ; Thu, 17 Apr 2008 02:23:18 +0300 In-Reply-To: (Stefan Monnier's message of "Tue, 15 Apr 2008 22:08:30 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: 7b1a4900bea4ee3727a65c989d5962bc X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2646 [Apr 16 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Info: {TO: local part of email appears in body} X-SpamTest-Method: none X-SpamTest-Rate: 15 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95374 Archived-At: >> + (defun internal-complete-buffer (string predicate flag) >> + (let ((table (mapcar 'buffer-name (buffer-list)))) > > Why not just use (mapcar 'buffer-name (buffer-list)) rather than using > a function as the completion table? > > If it's because of the hide-spaces argument to all-completions, then > please write a comment about it, The reason of adding the C version of internal-complete-buffer was the dynamic nature of the buffer list. This is described in detail in http://thread.gmane.org/gmane.emacs.devel/58453 Date: Wed, 16 Aug 2006 13:55:32 -0700 (PDT) From: "Stuart D. Herring" To: emacs-devel@gnu.org Fread_buffer directly uses Vbuffer_alist in its call to Fcompleting_read. This breaks if, while the minibuffer is active, the user switches buffers around. The cons which was the head of the list when Fread_buffer was called will in general no longer be at the head, and so part of the list will vanish for completion purposes. (Of course, it's slightly worse when REQUIRE-MATCH is set.) Similar problems result from creating or killing buffers during the call. I also have a vague suspicion that this procedure exposes the alist to modification by user code, but I can't think of how at the moment. Copying the alist for the call to Fcompleting_read (which is trivial to implement) would solve the reordering problems but not the ones involving creation/destruction; the real solution is to write a `complete-buffer' completion function that would re-consult the buffer list each time completion was needed. -- Juri Linkov http://www.jurta.org/emacs/