From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: NeXTstep (GNUstep/Cocoa) port and merging Date: Sat, 07 Jun 2008 20:29:32 -0400 Message-ID: <87od6ckbv7.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212885254 21915 80.91.229.12 (8 Jun 2008 00:34:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Jun 2008 00:34:14 +0000 (UTC) Cc: Adrian Robert , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 08 02:34:56 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K58s2-0007OF-8Z for ged-emacs-devel@m.gmane.org; Sun, 08 Jun 2008 02:34:54 +0200 Original-Received: from localhost ([127.0.0.1]:57700 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K58rF-0000eZ-42 for ged-emacs-devel@m.gmane.org; Sat, 07 Jun 2008 20:34:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K58rA-0000c6-2j for emacs-devel@gnu.org; Sat, 07 Jun 2008 20:34:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K58r6-0000W8-Ei for emacs-devel@gnu.org; Sat, 07 Jun 2008 20:33:58 -0400 Original-Received: from [199.232.76.173] (port=39108 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K58r6-0000W2-81 for emacs-devel@gnu.org; Sat, 07 Jun 2008 20:33:56 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:57058) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K58r6-00061n-Er for emacs-devel@gnu.org; Sat, 07 Jun 2008 20:33:56 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 7076C4E47E; Sat, 7 Jun 2008 20:29:32 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Tue, 03 Jun 2008 22:34:20 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98648 Archived-At: Stefan Monnier writes: >> One area it would be nice to have some feedback on is the added file >> "nsmenu_common.c". This file of about 1000 lines contains code that is >> more or less duplicated (modulo some divergence) across {x,w32,mac}menu.c, >> and is concerned mainly with mediating between lisp and C representations >> of menus. I followed xmenu.c when creating the common file. It would be >> good to change this to "menu_common.c" and have the other GUIs use it. > > Yes, it would indeed be good. I've already several times intended to > make a similar change but never got around to really do it. If someone > could take this part of the Emacs.app patch and make it independent from > Emacs.app, that would be great. I've been working on this, and it's nearly ready. I'll check in a platform-independent menu.c sometime this week. It will probably need a bit of help from those with access to w32 and mac to get it working properly on those platforms. I'll ping the list when it's checked in.