From: Phil Hagelberg <phil@hagelb.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: vc-register complains if a file is already registered in a git repository
Date: Tue, 28 Oct 2008 10:21:52 -0700 [thread overview]
Message-ID: <87od147hzj.fsf@hagelb.org> (raw)
In-Reply-To: <jwvvdvlxvgc.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 21 Oct 2008 21:37:21 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> It would probably be better for vc-git to provide another command, for that.
>>> We could probably add a `extra-keys' operation similar to `extra-menu'
>>> so that vc-git can not only provide a new command but also provide
>>> a specific C-x v <foo> key binding for it.
>
>> This would be great if we don't want to make the changes above. I can
>> add it. Could I get some details about extra-menu though? I'm not
>> familiar with it.
>
> Grep for extra-menu and extra-status-menu (which should be renamed
> extra-dir-menu, BTW) in vc*.el.
I've added the vc-git-register-changes command to vc-git-extra-menu-map
and will start work on creating extra-keys functionality that works like
extra-menu.
-Phil
diff --git a/lisp/vc-git.el b/lisp/vc-git.el
index 51ccc5d..773e6d3 100644
--- a/lisp/vc-git.el
+++ b/lisp/vc-git.el
@@ -622,6 +622,9 @@ or BRANCH^ (where \"^\" can be repeated)."
(define-key map [git-grep]
'(menu-item "Git grep..." vc-git-grep
:help "Run the `git grep' command"))
+ (define-key map [git-register-changes]
+ '(menu-item "Register changes" vc-git-register-changes
+ :help "Register the changes in the current buffer"))
map))
(defun vc-git-extra-menu () vc-git-extra-menu-map)
@@ -681,6 +684,12 @@ This command shares argument histories with \\[rgrep] and \\[grep]."
(compilation-start command 'grep-mode))
(if (eq next-error-last-buffer (current-buffer))
(setq default-directory dir))))))
+
+(defun vc-git-register-changes ()
+ "Register the changes in the current file to the staging area."
+ (interactive)
+ (vc-git-register buffer-file-name))
+
\f
;;; Internal commands
next prev parent reply other threads:[~2008-10-28 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 20:29 vc-register complains if a file is already registered in a git repository Phil Hagelberg
2008-10-21 21:43 ` Stefan Monnier
2008-10-21 22:23 ` Phil Hagelberg
2008-10-22 1:37 ` Stefan Monnier
2008-10-28 17:21 ` Phil Hagelberg [this message]
2008-10-28 18:19 ` Phil Hagelberg
2008-10-28 22:24 ` Phil Hagelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87od147hzj.fsf@hagelb.org \
--to=phil@hagelb.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.