bug#1417: 23.0.60; defmacro declare syntax trips up on offsets

bug#1417: 23.0.60; defmacro declare syntax trips up on offsets

[Brent Goodrick]

I might be doing something wrong with a declare usage in a
macro. However, the construct use used to work in Emacs 22, but does
not work in Emacs 23. I tried to post this to the #emacs channel, but
got no takers (Sun Nov 23 10:51:21 PST 2008).  I did verify this with
"emacs -q".  I am using Emacs built from top of HEAD CVS as of Sun Nov
23 10:28:46 PST 2008 (Xft emacs).

Steps to reproduce:

1. Run M-x eval-buffer on the chunk of Elisp code below.

2. Move point into the some-macro-using-function, and invoke C-u M-x
   edebug-eval-defun (which I think is bound to C-u M-C-x in a emacs -q
   session).

3. Then do M-x some-macro-using-function, and step through that
   function and verify no error occurs while stepping with the
   "n" key binding.

4. Uncomment the "declare" line inside the definition of `some-macro'.

5. Run M-x eval-buffer on this file again to get the new definition of `some-macro'.

6. Repeat step #2 above, but this time notice you get an error similar
   to: 

  edebug-form: Wrong type argument: number-or-marker-p, ((416 (417 . 421) (422 (422 . 423) (423 . 427) . 427) (428 (428 . 429) (429 . 433) . 433) (434 (434 . 435) (435 . 439) . 439) . 440) . 441)

Here is the chunk of Elisp code (in between the "cut here" lines):

-- cut here --
(defmacro some-macro (some-directory &rest body-forms)
  "Bla bla bla. Yada yada yada."
  ;; (declare (indent 1) (debug sexp body))
  `(list 'foo))

(defun some-macro-using-function ()
  "Yacki-yack, yack, yack."
  (interactive)
  (some-macro
	  "snickers/are/good/eating"
	(list 'some 'form 'here)))
-- cut here --



In GNU Emacs 23.0.60.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-23 on hungover
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--with-x-toolkit' '--with-xft' '--prefix=/home/brentg/emacs_from_source/install''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Help

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-netsplit-mode: t
  desktop-save-mode: t
  iswitchb-mode: t
  erc-ring-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  display-time-mode: t
  shell-dirtrack-mode: t
  delete-selection-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: 1
  transient-mark-mode: t
  view-mode: t

Recent input:
s <backspace> <backspace> e SPC s y n t a x ? <return> 
C-x o C-n C-n C-n C-n C-n C-n C-n <tab> <return> B 
C-n C-n M-n C-p C-l C-n C-n C-n C-n C-n C-n C-n C-l 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-l C-x o M-< C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n M-> M-x e m a c s - g b u <tab> <backspace> 
<backspace> <backspace> b u g <tab> <C-backspace> a 
p r o <tab> <return> b u g <return> C-x o C-x o C-s 
b u g - C-s C-s C-s C-s C-n C-n M-> C-s e m a c s C-s 
C-s C-s C-r C-r C-l C-s C-s C-s C-s C-s C-s C-s C-s 
C-r C-r C-s C-b <return> C-x o C-x o C-n C-x o C-n 
C-n C-x o C-n C-x o C-n C-x o C-n C-n C-n C-n C-n C-n 
C-n C-n M-x a p r o <tab> <return> r e p o r t . * 
b u g <return> C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-M-SPC C-z C-h f C-v <return> 
M-x b <backspace> C-v <return>

Recent messages:
Pushed a window configuration. [2 times]
Mark saved where search started
Pushed a window configuration. [2 times]
Mark saved where search started
Pushed a window configuration.
Type "q" to delete this window.
Mark set
Renamed transient buffer "*Help*" to "*Help*<3>"
Pushed a window configuration.
Type "q" to restore this window.

bug#1417: 23.0.60; defmacro declare syntax trips up on offsets

[Stefan Monnier]

> (defmacro some-macro (some-directory &rest body-forms)
>   "Bla bla bla. Yada yada yada."
>   ;; (declare (indent 1) (debug sexp body))
                                  ^^^^^^^^^
                                 (sexp body)

So the real bug is that this error is not caught in
`macro-declaration-function', and that error messages in Edebug's
parsing code are user-unfriendly.


        Stefan

bug#1417: 23.0.60; defmacro declare syntax trips up on offsets

[Brent Goodrick]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Agreed.  As a "rider clause" to this bug: the debug specification does not
seem to show up in the Elisp Info manual at all.

Thanks Stefan.

On Mon, Nov 24, 2008 at 8:11 AM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:

> > (defmacro some-macro (some-directory &rest body-forms)
> >   "Bla bla bla. Yada yada yada."
> >   ;; (declare (indent 1) (debug sexp body))
>                                  ^^^^^^^^^
>                                 (sexp body)
>
> So the real bug is that this error is not caught in
> `macro-declaration-function', and that error messages in Edebug's
> parsing code are user-unfriendly.
>
>
>        Stefan
>

[-- Attachment #2: Type: text/html, Size: 1207 bytes --]

bug#1417: marked as done (23.0.60; defmacro declare syntax trips up on offsets)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]


Your message dated Sat, 29 Nov 2008 22:01:31 -0500
with message-id <87ljv1diic.fsf@cyd.mit.edu>
and subject line Re: bug#1417: 23.0.60; defmacro declare syntax trips up on offsets
has caused the Emacs bug report #1417,
regarding 23.0.60; defmacro declare syntax trips up on offsets
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1417: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1417
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6371 bytes --]

From: Brent Goodrick <bgoodr@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; defmacro declare syntax trips up on offsets
Date: Sun, 23 Nov 2008 10:57:07 -0800
Message-ID: <87od06w9rw.fsf@hungover.brentg.com>

I might be doing something wrong with a declare usage in a
macro. However, the construct use used to work in Emacs 22, but does
not work in Emacs 23. I tried to post this to the #emacs channel, but
got no takers (Sun Nov 23 10:51:21 PST 2008).  I did verify this with
"emacs -q".  I am using Emacs built from top of HEAD CVS as of Sun Nov
23 10:28:46 PST 2008 (Xft emacs).

Steps to reproduce:

1. Run M-x eval-buffer on the chunk of Elisp code below.

2. Move point into the some-macro-using-function, and invoke C-u M-x
   edebug-eval-defun (which I think is bound to C-u M-C-x in a emacs -q
   session).

3. Then do M-x some-macro-using-function, and step through that
   function and verify no error occurs while stepping with the
   "n" key binding.

4. Uncomment the "declare" line inside the definition of `some-macro'.

5. Run M-x eval-buffer on this file again to get the new definition of `some-macro'.

6. Repeat step #2 above, but this time notice you get an error similar
   to: 

  edebug-form: Wrong type argument: number-or-marker-p, ((416 (417 . 421) (422 (422 . 423) (423 . 427) . 427) (428 (428 . 429) (429 . 433) . 433) (434 (434 . 435) (435 . 439) . 439) . 440) . 441)

Here is the chunk of Elisp code (in between the "cut here" lines):

-- cut here --
(defmacro some-macro (some-directory &rest body-forms)
  "Bla bla bla. Yada yada yada."
  ;; (declare (indent 1) (debug sexp body))
  `(list 'foo))

(defun some-macro-using-function ()
  "Yacki-yack, yack, yack."
  (interactive)
  (some-macro
	  "snickers/are/good/eating"
	(list 'some 'form 'here)))
-- cut here --



In GNU Emacs 23.0.60.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-23 on hungover
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--with-x-toolkit' '--with-xft' '--prefix=/home/brentg/emacs_from_source/install''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Help

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-netsplit-mode: t
  desktop-save-mode: t
  iswitchb-mode: t
  erc-ring-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  display-time-mode: t
  shell-dirtrack-mode: t
  delete-selection-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: 1
  transient-mark-mode: t
  view-mode: t

Recent input:
s <backspace> <backspace> e SPC s y n t a x ? <return> 
C-x o C-n C-n C-n C-n C-n C-n C-n <tab> <return> B 
C-n C-n M-n C-p C-l C-n C-n C-n C-n C-n C-n C-n C-l 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-l C-x o M-< C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n M-> M-x e m a c s - g b u <tab> <backspace> 
<backspace> <backspace> b u g <tab> <C-backspace> a 
p r o <tab> <return> b u g <return> C-x o C-x o C-s 
b u g - C-s C-s C-s C-s C-n C-n M-> C-s e m a c s C-s 
C-s C-s C-r C-r C-l C-s C-s C-s C-s C-s C-s C-s C-s 
C-r C-r C-s C-b <return> C-x o C-x o C-n C-x o C-n 
C-n C-x o C-n C-x o C-n C-x o C-n C-n C-n C-n C-n C-n 
C-n C-n M-x a p r o <tab> <return> r e p o r t . * 
b u g <return> C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-M-SPC C-z C-h f C-v <return> 
M-x b <backspace> C-v <return>

Recent messages:
Pushed a window configuration. [2 times]
Mark saved where search started
Pushed a window configuration. [2 times]
Mark saved where search started
Pushed a window configuration.
Type "q" to delete this window.
Mark set
Renamed transient buffer "*Help*" to "*Help*<3>"
Pushed a window configuration.
Type "q" to restore this window.



[-- Attachment #3: Type: message/rfc822, Size: 1137 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Brent Goodrick <bgoodr@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 1417-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1417: 23.0.60; defmacro declare syntax trips up on offsets
Date: Sat, 29 Nov 2008 22:01:31 -0500
Message-ID: <87ljv1diic.fsf@cyd.mit.edu>

I've checked in a fix to make `macro-declaration-function' complain on
such problematic declarations.