From: Kevin Ryde <user42@zip.com.au>
To: bug-gnu-emacs@gnu.org
Subject: bug#4818: 23.1; checkdoc noun at end of sentence
Date: Wed, 28 Oct 2009 10:34:12 +1100 [thread overview]
Message-ID: <87ocnsqumj.fsf@blah.blah> (raw)
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
Running M-x checkdoc over the foo.el below I hoped it would ask to
capitalize "emacs" to "Emacs" in each of the three places. A real-life
example can be found in `vi-save-all-and-exit' of vi.el.
I suspect the \\_> in checkdoc-proper-noun-regexp doesn't match a "." at
the end of a sentence. Would relaxing that a bit like below cause any
false positives?
Incidentally, checkdoc-proper-noun-regexp could build its value with
regexp-opt could it? Not that it needs to be optimized, just easier
than an explicit concatenating loop.
2009-10-27 Kevin Ryde <user42@zip.com.au>
* emacs-lisp/checkdoc.el (checkdoc-proper-noun-regexp): Match noun
at end of sentence.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: checkdoc.el.noun-end-sentence.diff --]
[-- Type: text/x-diff, Size: 794 bytes --]
--- checkdoc.el.~1.79.~ 2009-10-28 09:39:24.000000000 +1100
+++ checkdoc.el 2009-10-28 10:25:24.000000000 +1100
@@ -331,12 +331,15 @@
"List of words (not capitalized) which should be capitalized.")
(defvar checkdoc-proper-noun-regexp
+ ;; "[.!?]" bit is for noun at end of a sentence, since those chars
+ ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>.
+ ;; The \" allows it to be the last sentence in a docstring too.
(let ((expr "\\_<\\(")
(l checkdoc-proper-noun-list))
(while l
(setq expr (concat expr (car l) (if (cdr l) "\\|" ""))
l (cdr l)))
- (concat expr "\\)\\_>"))
+ (concat expr "\\)\\(\\_>\\|[.!?][ \t\n\"]\\)"))
"Regular expression derived from `checkdoc-proper-noun-regexp'.")
(defvar checkdoc-common-verbs-regexp nil
[-- Attachment #3: foo.el --]
[-- Type: application/emacs-lisp, Size: 201 bytes --]
[-- Attachment #4: Type: text/plain, Size: 1076 bytes --]
In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
of 2009-09-14 on raven, modified by Debian
configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_AU
value of $XMODIFIERS: nil
locale-coding-system: iso-latin-1-unix
default-enable-multibyte-characters: t
next reply other threads:[~2009-10-27 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <873a4osmit.fsf@blah.blah>
2009-10-27 23:34 ` Kevin Ryde [this message]
2009-11-08 22:10 ` bug#4818: marked as done (23.1; checkdoc noun at end of sentence) Emacs bug Tracking System
2009-11-07 19:14 bug#4818: 23.1; checkdoc noun at end of sentence Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocnsqumj.fsf@blah.blah \
--to=user42@zip.com.au \
--cc=4818@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.