From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: emacs-devel@gnu.org
Subject: alloca() warnings on freebsd
Date: Tue, 10 Aug 2010 01:09:44 +0300 [thread overview]
Message-ID: <87ocdbbfpz.fsf@kobe.laptop> (raw)
Some time during the recent past an alloca() prototype was introduced to
config.h that conflicts with the stdlib.h prototype of alloca() on my
FreeBSD laptop.
The current check near line 1148 of config.in is:
#ifdef HAVE_ALLOCA_H
# include <alloca.h>
#elif defined __GNUC__
# define alloca __builtin_alloca
#elif defined _AIX
# define alloca __alloca
#else
# include <stddef.h>
# ifdef __cplusplus
extern "C"
# endif
void *alloca (size_t);
#endif
The tricky bit is that FreeBSD *does* have alloca() but not alloca.h, so
the final #else part declares a redundant prototype. This causes a very
minor but frequent warning for all source files that include config.h:
In file included from /hg/emacs/gker/lib-src/test-distrib.c:23:
../src/config.h:1152:1: warning: "alloca" redefined
In file included from ../src/config.h:1146,
from /hg/emacs/gker/lib-src/test-distrib.c:23:
/usr/include/stdlib.h:233:1: warning: this is the location of the previous definition
...
The attached patch is an attempt to fix this for FreeBSD without
breaking alloca() on other platforms.
Does it look ok for trunk?
%%%
diff -r eb8d82184a6f -r c422057d6385 ChangeLog
--- a/ChangeLog Mon Aug 09 10:08:56 2010 -0700
+++ b/ChangeLog Tue Aug 10 01:06:38 2010 +0300
@@ -1,3 +1,9 @@
+2010-08-09 Giorgos Keramidas <keramida@ceid.upatras.gr>
+
+ * configure.in: Avoid declaring a redundant prototype of alloca()
+ when we HAVE_ALLOCA but not HAVE_ALLOCA_H (e.g. on FreeBSD systems
+ where alloca() is declared in stdlib.h).
+
2010-08-09 Dan Nicolaescu <dann@ics.uci.edu>
* configure.in (ORDINARY_LINK): Use on hpux* too.
diff -r eb8d82184a6f -r c422057d6385 configure.in
--- a/configure.in Mon Aug 09 10:08:56 2010 -0700
+++ b/configure.in Tue Aug 10 01:06:38 2010 +0300
@@ -3574,16 +3574,18 @@ SYSTEM_PURESIZE_EXTRA seems like the lea
#ifdef HAVE_ALLOCA_H
# include <alloca.h>
-#elif defined __GNUC__
-# define alloca __builtin_alloca
-#elif defined _AIX
-# define alloca __alloca
-#else
-# include <stddef.h>
-# ifdef __cplusplus
+#elif !defined(HAVE_ALLOCA)
+# if defined __GNUC__
+# define alloca __builtin_alloca
+# elif defined _AIX
+# define alloca __alloca
+# else
+# include <stddef.h>
+# ifdef __cplusplus
extern "C"
+# endif
+void *alloca (size_t);
# endif
-void *alloca (size_t);
#endif
#ifndef HAVE_SIZE_T
diff -r eb8d82184a6f -r c422057d6385 src/ChangeLog
--- a/src/ChangeLog Mon Aug 09 10:08:56 2010 -0700
+++ b/src/ChangeLog Tue Aug 10 01:06:38 2010 +0300
@@ -1,3 +1,9 @@
+2010-08-09 Giorgos Keramidas <keramida@ceid.upatras.gr>
+
+ * config.in: Avoid declaring a redundant prototype of alloca()
+ when we HAVE_ALLOCA but not HAVE_ALLOCA_H (e.g. on FreeBSD systems
+ where alloca() is declared in stdlib.h).
+
2010-08-09 Dan Nicolaescu <dann@ics.uci.edu>
Use const char* instead of char*.
diff -r eb8d82184a6f -r c422057d6385 src/config.in
--- a/src/config.in Mon Aug 09 10:08:56 2010 -0700
+++ b/src/config.in Tue Aug 10 01:06:38 2010 +0300
@@ -1147,16 +1147,18 @@ SYSTEM_PURESIZE_EXTRA seems like the lea
#ifdef HAVE_ALLOCA_H
# include <alloca.h>
-#elif defined __GNUC__
-# define alloca __builtin_alloca
-#elif defined _AIX
-# define alloca __alloca
-#else
-# include <stddef.h>
-# ifdef __cplusplus
+#elif !defined(HAVE_ALLOCA)
+# if defined __GNUC__
+# define alloca __builtin_alloca
+# elif defined _AIX
+# define alloca __alloca
+# else
+# include <stddef.h>
+# ifdef __cplusplus
extern "C"
+# endif
+void *alloca (size_t);
# endif
-void *alloca (size_t);
#endif
#ifndef HAVE_SIZE_T
%%%
next reply other threads:[~2010-08-09 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 22:09 Giorgos Keramidas [this message]
2010-08-09 23:16 ` alloca() warnings on freebsd Dan Nicolaescu
2010-08-10 9:38 ` Giorgos Keramidas
2010-09-07 19:01 ` Giorgos Keramidas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocdbbfpz.fsf@kobe.laptop \
--to=keramida@ceid.upatras.gr \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.