From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eduard Wiebe Newsgroups: gmane.emacs.bugs Subject: bug#7308: [patch] locate under windoze Date: Sat, 13 Nov 2010 23:33:08 +0100 Message-ID: <87oc9sq2fv.fsf@pusto.de> References: <87hbg3piit.fsf@pusto.de> <87d3qpytrx.fsf@pusto.de> <87wroiuvzy.fsf@pusto.de> <87mxpdkq68.fsf@stupidchicken.com> <8339r4exco.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289688278 18256 80.91.229.12 (13 Nov 2010 22:44:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 13 Nov 2010 22:44:38 +0000 (UTC) Cc: 7308@debbugs.gnu.org, Chong Yidong To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 13 23:44:33 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PHOpd-0001Px-V8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Nov 2010 23:44:29 +0100 Original-Received: from localhost ([127.0.0.1]:52808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHOpT-0002Zh-5k for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Nov 2010 17:44:15 -0500 Original-Received: from [140.186.70.92] (port=58310 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHOpK-0002XT-V1 for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 17:44:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHOpG-0005Js-Gd for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 17:44:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHOpG-0005Jo-DF for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 17:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PHObj-0006QD-0l; Sat, 13 Nov 2010 17:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eduard Wiebe Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Nov 2010 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7308 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7308-submit@debbugs.gnu.org id=B7308.128968738724662 (code B ref 7308); Sat, 13 Nov 2010 22:30:02 +0000 Original-Received: (at 7308) by debbugs.gnu.org; 13 Nov 2010 22:29:47 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PHObS-0006Pj-BM for submit@debbugs.gnu.org; Sat, 13 Nov 2010 17:29:46 -0500 Original-Received: from wp093.webpack.hosteurope.de ([80.237.132.100]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PHObN-0006Pe-Cn for 7308@debbugs.gnu.org; Sat, 13 Nov 2010 17:29:45 -0500 Original-Received: from g225219097.adsl.alicedsl.de ([92.225.219.97] helo=nirvana); authenticated by wp093.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) id 1PHOg3-00053F-HG; Sat, 13 Nov 2010 23:34:31 +0100 Original-Received: from ew by nirvana with local (Exim 4.69) (envelope-from ) id 1PHOei-0002HK-Sk; Sat, 13 Nov 2010 23:33:08 +0100 In-Reply-To: <8339r4exco.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Nov 2010 23:18:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-bounce-key: webpack.hosteurope.de;ew@pusto.de;1289687679;e6a16fb8; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 13 Nov 2010 17:30:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41591 Archived-At: Eli Zaretskii writes: >> From: Chong Yidong >> Cc: Eduard Wiebe , 7308@debbugs.gnu.org >> Date: Sat, 13 Nov 2010 13:57:03 -0500 >> >> Eduard Wiebe writes: >> >> > Eduard Wiebe writes: >> > >> > Ping. >> >> Eli, are you happy with the patch introducing the backslash changes from >> >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7308#50 >> >> ? It looks OK to me, but I am not sure I've correctly followed the >> discussion in this bug report. > > I'm okay with the main change, but I don't understand the reason (or > need) for this hunk: > > @@ -473,9 +483,9 @@ do not work in subdirectories. > (make-local-variable 'directory-listing-before-filename-regexp) > ;; This should support both Unix and Windoze style names > (setq directory-listing-before-filename-regexp > - (concat "^." > + (concat "^.\\(" > (make-string (1- locate-filename-indentation) ?\s) > - "\\(/\\|[A-Za-z]:\\)\\|" ^^^^^^^^^^^^^^^^^^^^ > + "\\)\\|" > (default-value 'directory-listing-before-filename-regexp))) > (make-local-variable 'dired-actual-switches) > (setq dired-actual-switches "") This hunk is essential. The new value of the regexp avoids the truncation of the drive letter from absolute path of the selected file. Btw. Under GNU/Linux this change leads to correct position of cursor in *Locate* buffer, too. PS: I tested my patch under GNU/Linux with GNU locate und MS-Windows with everything-Tool for a while and it works fine. -- Eduard Wiebe