From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: machine specific patch (OpenBSD) Date: Tue, 19 Jul 2011 11:52:10 +0200 Message-ID: <87oc0q8unp.fsf@univ-nantes.fr> References: <871uxucls5.fsf@univ-nantes.fr> <87wrfmb3ye.fsf@univ-nantes.fr> <4E1E2399.50506@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1311069165 7631 80.91.229.12 (19 Jul 2011 09:52:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2011 09:52:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 19 11:52:36 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qj6yi-0003nE-KB for ged-emacs-devel@m.gmane.org; Tue, 19 Jul 2011 11:52:36 +0200 Original-Received: from localhost ([::1]:43683 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qj6yh-0002ZM-Md for ged-emacs-devel@m.gmane.org; Tue, 19 Jul 2011 05:52:35 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qj6yQ-0002Z5-7B for emacs-devel@gnu.org; Tue, 19 Jul 2011 05:52:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qj6yL-0008Jh-L7 for emacs-devel@gnu.org; Tue, 19 Jul 2011 05:52:18 -0400 Original-Received: from smtp-tls1.univ-nantes.fr ([193.52.101.145]:34961 helo=smtp-tls.univ-nantes.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qj6yL-0008J9-Bj for emacs-devel@gnu.org; Tue, 19 Jul 2011 05:52:13 -0400 Original-Received: from localhost (debian [127.0.0.1]) by smtp-tls.univ-nantes.fr (Postfix) with ESMTP id 6F99394E1F; Tue, 19 Jul 2011 11:52:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at univ-nantes.fr Original-Received: from smtp-tls.univ-nantes.fr ([127.0.0.1]) by localhost (smtp-tls1.d101.univ-nantes.fr [127.0.0.1]) (amavisd-new, port 10024) with LMTP id F9pNppceeL7I; Tue, 19 Jul 2011 11:52:11 +0200 (CEST) Original-Received: from K (unknown [172.16.13.134]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp-tls.univ-nantes.fr (Postfix) with ESMTPSA id 5D46494DB2; Tue, 19 Jul 2011 11:52:11 +0200 (CEST) In-Reply-To: <4E1E2399.50506@cs.ucla.edu> (Paul Eggert's message of "Wed, 13 Jul 2011 16:00:41 -0700") User-Agent: Gnus/5.1299999999999999 (Gnus v5.13) Emacs/23.3 (berkeley-unix) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 193.52.101.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:142149 Archived-At: Paul Eggert writes: > On 07/13/11 08:22, Manuel Giraud wrote: > >> Ok, so far I've updated those: > > > doesn't seem to be updated; it was last changed 3 months ago. Are the > updated patches available anywhere other than in your email? They are just in my email. The patches from the openbsd cvsweb are the ones to make the last stable version of emacs (23.3) to work under openbsd and make an installable package out of it. I just like to have some stuff in the emacs repo in order to have emacs 24 eventually working "out of the box" on openbsd. >> I didn't include others because they are related to mips64 and alpha >> arch and i cannot test it. > > Has anyone tested them? Not me, I don't have the hardware. jasper@ seems to have tested and updated them. > The two mips64 files seem long enough that they'll require copyright > assignment papers. Did you write them? If not, who? There is a FSF copyright, is it enough? I didn't write this file, it seems to come frome here and is almost 6 years old. >>> +#define BROKEN_SIGIO > > Could you please explain why that's needed? Is there some discussion > of this somewhere? It'd be helpful to have that in a comment > somewhere. There was a discussion here: http://marc.info/?l=openbsd-ports&m=128932473227826&w=2 and a solution found by Mike Belopuhov, here: http://marc.info/?l=openbsd-ports&m=130019184729434&w=2 > Regarding the minibuf.c patch: > > Is a similar patch (for fgets) needed in xfaces.c's Fx_load_color_file > function, for the case where Emacs is configured without HAVE_X_WINDOWS? > > The minibuf.c patch is a bit confusing, with gotos and suchlike. > Does the following patch fix the problem as well? It's a longer patch, > but the resulting code should be more straightforward. It works and I too prefer this one. -- Manuel Giraud