all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: 8657@debbugs.gnu.org
Subject: bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly
Date: Tue, 07 Feb 2012 13:57:45 +0800	[thread overview]
Message-ID: <87obtbxk12.fsf@gnu.org> (raw)
In-Reply-To: <b4mk43zpo3t.fsf@jpl.org> (Katsumi Yamaoka's message of "Tue, 07 Feb 2012 07:56:54 +0900")

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> But in XEmacs next-single-char-property-change will return nil
> if no property change is found.

Ah OK, thanks for checking.

> So I've modified the gnus-sum.el code into:
>
>   (if (featurep 'xemacs)
>       (or (next-single-char-property-change end 'invisible)
>           (point-max))
>     (next-single-char-property-change end 'invisible))

I suggest just restoring the old code, and adding a comment about why
the `or' is there.





  reply	other threads:[~2012-02-07  5:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 20:54 bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly Drew Adams
2011-05-12  3:05 ` Stefan Monnier
2011-05-12  4:44   ` Eli Zaretskii
2011-05-12 13:44     ` bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change'incorrectly Drew Adams
2012-02-06 14:00     ` bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly Chong Yidong
2012-02-06 22:56       ` Katsumi Yamaoka
2012-02-07  5:57         ` Chong Yidong [this message]
2012-02-07  6:34           ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obtbxk12.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=8657@debbugs.gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.