From: Juri Linkov <juri@jurta.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 10857@debbugs.gnu.org
Subject: bug#10857: ucs-insert deals inconsistently with errors
Date: Tue, 21 Feb 2012 02:37:38 +0200 [thread overview]
Message-ID: <87obstt2n9.fsf@mail.jurta.org> (raw)
In-Reply-To: <CAAeL0STxcxOHg2YSOpeDeCFbre+AzhGBoGRhtwGW1xaUc0zb4A@mail.gmail.com> (Juanma Barranquero's message of "Mon, 20 Feb 2012 16:53:56 +0100")
> 1) M-x ucs-insert <RET> zzz <RET> => "Not a Unicode character code: nil"
> Which is caused by `read-char-by-name' not having a way to pass
> back what the user really typed. Still, I typed "zzz", not "nil", so
> the message is unhelpful.
Wouldn't it be too weird for `read-char-by-name' to return "zzz"
when the purpose of this function is to return a character,
not a string the user typed.
> 2) When called from lisp code, it deals differently with erroneous
> strings and erroneous non-strings:
> (ucs-insert 'zzz) => "Not a Unicode character code: zzz" ;; correct
> (ucs-insert "zzz") => any non-hex string is turned into ^@ and
> inserted, and no error is produced.
>
> The second problem can be trivially fixed with
> (not (string-match-p "[^[:xdigit:]]" character)),
In `read-char-by-name', the condition for this purpose is:
(string-match-p "^[0-9a-fA-F]+$" input)
next prev parent reply other threads:[~2012-02-21 0:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 15:53 bug#10857: ucs-insert deals inconsistently with errors Juanma Barranquero
2012-02-21 0:37 ` Juri Linkov [this message]
2012-02-21 1:25 ` Juanma Barranquero
2012-02-21 9:16 ` Andreas Schwab
2012-02-21 10:39 ` Juanma Barranquero
2012-02-22 0:09 ` Juri Linkov
2012-02-22 9:03 ` Andreas Schwab
2012-02-22 23:35 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obstt2n9.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=10857@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.