From: Kenichi Handa <handa@m17n.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11082@debbugs.gnu.org
Subject: bug#11082: 24.0.94; u.glyphless member in struct glyph does not fit in 32 bits
Date: Mon, 26 Mar 2012 14:47:16 +0900 [thread overview]
Message-ID: <87obrjncbf.fsf@m17n.org> (raw)
In-Reply-To: <83zkb6trdb.fsf@gnu.org> (message from Eli Zaretskii on Sat, 24 Mar 2012 09:01:04 +0200)
In article <83zkb6trdb.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> > 447 /* Sub-stretch for type == GLYPHLESS_GLYPH. */
> > 448 struct
> > 449 {
> > 450 /* Value is an enum of the type glyphless_display_method. */
> > 451 unsigned method : 2;
> > 452 /* 1 iff this glyph is for a character of no font. */
> > 453 unsigned for_no_font : 1;
> > 454 /* Length of acronym or hexadecimal code string (at most 8). */
> > 455 unsigned len : 4;
> > 456 /* Character to display. Actually we need only 22 bits. */
> > 457 unsigned ch : 26;
> > 458 } glyphless;
[...]
> > According to the comment above, it seems to be OK to shorten the
> > length of `u.glyphless.ch' member from 26 to 25. Could someone
> > confirm this?
> Confirmed. From the ELisp manual:
[...]
> I would actually suggest to use 22-bit for this field, to avoid
> confusion in the future.
I agree to change the bit length. I don't remeber well but I
think the current bit length setting was just my mistake.
In article <jwv4ntch6w6.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > dispextern.h (struct glyph): Change the bit length of glyphless.ch to 22
> > to make the member glyphless fit in 32 bits.
> I think it's safer to reduce it to 25 bits, otherwise `val' field will
> refer to undefined bits.
Ok. I've just installed that change.
---
Kenichi Handa
handa@m17n.org
prev parent reply other threads:[~2012-03-26 5:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 5:23 bug#11082: 24.0.94; u.glyphless member in struct glyph does not fit in 32 bits YAMAMOTO Mitsuharu
2012-03-24 7:01 ` Eli Zaretskii
2012-03-24 8:54 ` Andreas Schwab
2012-03-25 0:29 ` YAMAMOTO Mitsuharu
2012-03-26 5:47 ` Kenichi Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obrjncbf.fsf@m17n.org \
--to=handa@m17n.org \
--cc=11082@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.