From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: toggle-read-only should not give compilation warnings Date: Fri, 13 Jul 2012 21:47:49 +0800 Message-ID: <87obnjai2i.fsf@gnu.org> References: <877gubszqq.fsf@gnu.org> <87txxcgrq2.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1342187299 11547 80.91.229.3 (13 Jul 2012 13:48:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 13 Jul 2012 13:48:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 13 15:48:18 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SpgEE-0004MU-CZ for ged-emacs-devel@m.gmane.org; Fri, 13 Jul 2012 15:48:18 +0200 Original-Received: from localhost ([::1]:50478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpgED-0001pO-OS for ged-emacs-devel@m.gmane.org; Fri, 13 Jul 2012 09:48:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpgE6-0001oZ-0Q for emacs-devel@gnu.org; Fri, 13 Jul 2012 09:48:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SpgDv-0003lp-58 for emacs-devel@gnu.org; Fri, 13 Jul 2012 09:48:09 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:33997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpgDv-0003ll-1z for emacs-devel@gnu.org; Fri, 13 Jul 2012 09:47:59 -0400 Original-Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:52523 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SpgDr-0005wZ-PR; Fri, 13 Jul 2012 09:47:57 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 13 Jul 2012 09:04:27 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151592 Archived-At: Stefan Monnier writes: > Once we're sure that the remaining calls to toggle-read-only are all > "correct", we should try to understand why that is and provide some > alternative function for that (and make toggle-read-only use that > function, of course). It's not difficult to see why the remaining calls are correct: they want to do the same thing as C-x C-q, either acting on a different buffer or with a different interactive invocation. Examples include mode-line-toggle-read-only and Buffer-menu-toggle-read-only. Adding another function, rather than simply using toggle-read-only, is an unnecessary level of indirection.