From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#12503: `bookmark-write-file' should bind `print-circle' to t Date: Sun, 30 Sep 2012 22:48:55 -0500 Message-ID: <87obkmhmxk.fsf@floss.red-bean.com> References: Reply-To: Karl Fogel NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349063383 11441 80.91.229.3 (1 Oct 2012 03:49:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 03:49:43 +0000 (UTC) To: 12503-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 01 05:49:48 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIX0t-0004WN-VP for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2012 05:49:48 +0200 Original-Received: from localhost ([::1]:35766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIX0o-0007vr-Er for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2012 23:49:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIX0l-0007vV-Hl for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:49:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIX0k-0002wC-Ld for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:49:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIX0k-0002vv-Hb for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:49:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TIX18-00015k-8a for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:50:02 -0400 In-Reply-To: Resent-From: Karl Fogel Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Oct 2012 03:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 12503@debbugs.gnu.org, kfogel@red-bean.com Original-Received: via spool by 12503-done@debbugs.gnu.org id=D12503.13490633674144 (code D ref 12503); Mon, 01 Oct 2012 03:50:01 +0000 Original-Received: (at 12503-done) by debbugs.gnu.org; 1 Oct 2012 03:49:27 +0000 Original-Received: from localhost ([127.0.0.1]:35333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIX0Z-00014n-4v for submit@debbugs.gnu.org; Sun, 30 Sep 2012 23:49:27 -0400 Original-Received: from mail-ie0-f172.google.com ([209.85.223.172]:53856) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIX0W-00014d-V5 for 12503-done@debbugs.gnu.org; Sun, 30 Sep 2012 23:49:25 -0400 Original-Received: by iec9 with SMTP id 9so11839026iec.3 for <12503-done@debbugs.gnu.org>; Sun, 30 Sep 2012 20:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:reply-to:date:message-id:mime-version :content-type; bh=zoh3Kh/fH515nJhqogCJCM6wRfKtz/Zjk8sPwg4F4KM=; b=MztVEjJCO0oacqRUXiRZnzrhJCYSzM8wU+yuS1Jf/1myO2XGKPyMUTca3wrL7gVF2U lIs8hZya36RfoR5NMLHaCNpGU1cnukN0aaPVj9/BbT6IuK4WcdC/9cHl63AWaxHV8qDs 6MOwCV9BGchYTM2zh5PgZa6+mtt6T4VSNeqtSYxlk64q+7D/wrNwp8jkgZRige1mqnZB UNxOgFTidURyK3WBBiupRoIeQ6qEvh9oGUqAfOp+vspIml/zEtaNUIZi2hSh0hnwA2Pv eZlZETjbRxRo2OrOUeBQ4PAiMxxngwbW0MRJ7WYEhpT7MQNwJP8Z4iydeUHgAzOdRZEm vUmg== Original-Received: by 10.50.163.70 with SMTP id yg6mr4458956igb.30.1349063340373; Sun, 30 Sep 2012 20:49:00 -0700 (PDT) Original-Received: from floss.red-bean.com (173-109-178-220.pools.spcsdns.net. [173.109.178.220]) by mx.google.com with ESMTPS id uj6sm6195183igb.4.2012.09.30.20.48.58 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 30 Sep 2012 20:48:59 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65044 Archived-At: Done: revno: 110307 revision-id: kfogel@red-bean.com-20121001034459-o8irfybe8zo6mum6 parent: kfogel@red-bean.com-20121001033402-6jrmk69xzz30h3zw committer: Karl Fogel branch nick: trunk timestamp: Sun 2012-09-30 22:44:59 -0500 message: * lisp/bookmark.el (bookmark-write-file): Bind `print-circle' to `t' here to allow circular custom bookmark types. (Bug#12503) Diff: --- lisp/bookmark.el 2012-10-01 03:34:02 +0000 +++ lisp/bookmark.el 2012-10-01 03:41:42 +0000 @@ -1359,7 +1359,12 @@ (goto-char (point-min)) (delete-region (point-min) (point-max)) (let ((print-length nil) - (print-level nil)) + (print-level nil) + ;; See bug #12503 for why we bind `print-circle'. Users + ;; can define their own bookmark types, which can result in + ;; arbitrary Lisp objects being stored in bookmark records, + ;; and some users create objects containing circularities. + (print-circle t)) (bookmark-insert-file-format-version-stamp) (insert "(") ;; Rather than a single call to `pp' we make one per bookmark.