From: Karl Fogel <kfogel@red-bean.com>
To: 12503-done@debbugs.gnu.org
Subject: bug#12503: `bookmark-write-file' should bind `print-circle' to t
Date: Sun, 30 Sep 2012 22:48:55 -0500 [thread overview]
Message-ID: <87obkmhmxk.fsf@floss.red-bean.com> (raw)
In-Reply-To: <CF526201BBBF465684D08081F0C9C0DC@us.oracle.com>
Done:
revno: 110307
revision-id: kfogel@red-bean.com-20121001034459-o8irfybe8zo6mum6
parent: kfogel@red-bean.com-20121001033402-6jrmk69xzz30h3zw
committer: Karl Fogel <kfogel@red-bean.com>
branch nick: trunk
timestamp: Sun 2012-09-30 22:44:59 -0500
message:
* lisp/bookmark.el (bookmark-write-file): Bind `print-circle' to `t'
here to allow circular custom bookmark types. (Bug#12503)
Diff:
--- lisp/bookmark.el 2012-10-01 03:34:02 +0000
+++ lisp/bookmark.el 2012-10-01 03:41:42 +0000
@@ -1359,7 +1359,12 @@
(goto-char (point-min))
(delete-region (point-min) (point-max))
(let ((print-length nil)
- (print-level nil))
+ (print-level nil)
+ ;; See bug #12503 for why we bind `print-circle'. Users
+ ;; can define their own bookmark types, which can result in
+ ;; arbitrary Lisp objects being stored in bookmark records,
+ ;; and some users create objects containing circularities.
+ (print-circle t))
(bookmark-insert-file-format-version-stamp)
(insert "(")
;; Rather than a single call to `pp' we make one per bookmark.
prev parent reply other threads:[~2012-10-01 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 16:11 bug#12503: 24.2.50; `bookmark-write-file' should bind `print-circle' to t Drew Adams
2012-10-01 3:48 ` Karl Fogel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obkmhmxk.fsf@floss.red-bean.com \
--to=kfogel@red-bean.com \
--cc=12503-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.