From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#11095: 24.0.94; hi-lock-face-buffer/unhighlight-regexp': Augment? Date: Sat, 13 Oct 2012 22:58:58 +0530 Message-ID: <87obk6l1r9.fsf@gmail.com> References: <81d37z271c.fsf@gmail.com> <87y5jcvjsx.fsf@gmail.com> <87zk3s1vjz.fsf@mail.jurta.org> <87lifc71o0.fsf@gmail.com> <87vceez7ib.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1350149291 12272 80.91.229.3 (13 Oct 2012 17:28:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Oct 2012 17:28:11 +0000 (UTC) Cc: 11095@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 13 19:28:18 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TN5VY-0001se-2g for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Oct 2012 19:28:16 +0200 Original-Received: from localhost ([::1]:33571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TN5VR-0003LV-54 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Oct 2012 13:28:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TN5VO-0003LQ-Rv for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2012 13:28:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TN5VN-0004k7-Nu for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2012 13:28:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TN5VN-0004k3-J5 for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2012 13:28:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TN5WI-0008NC-5d for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2012 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Oct 2012 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11095-submit@debbugs.gnu.org id=B11095.135014931732156 (code B ref 11095); Sat, 13 Oct 2012 17:29:02 +0000 Original-Received: (at 11095) by debbugs.gnu.org; 13 Oct 2012 17:28:37 +0000 Original-Received: from localhost ([127.0.0.1]:42753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TN5Vs-0008Ma-Hl for submit@debbugs.gnu.org; Sat, 13 Oct 2012 13:28:36 -0400 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]:48500) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TN5Vq-0008MN-63 for 11095@debbugs.gnu.org; Sat, 13 Oct 2012 13:28:35 -0400 Original-Received: by mail-pb0-f44.google.com with SMTP id ro8so3773800pbb.3 for <11095@debbugs.gnu.org>; Sat, 13 Oct 2012 10:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=jPdPqsDUh4vAH39f8jLsYWSYiHfZTqQizSt6x/Xiz4o=; b=aXTO3LTw2RU1NEQCfCoaOaQ6ldePmQ7csWV4PfuwFwCfBdzl6THHRG+EQy677gQFHj CuS+6PalorY6WLtjh/uIYR8pPbqdj3R9i5YMqTsPwPD6mLB/33Q/0J1g9dq5QDAaEdw7 faizEGw6V48MoTe9IdUpbvhoVji1qgLh4a8e299KXHPJrenOD5uHKOE3Isl6QX4gAc3N aBNjNtnii51IV6+vT/sHrxsnl3JCJ21owAdF0dwgawfXDgp4VjUl1np84wxeqhMePtv7 zbgTs4gljFt027hUXuhcshBmSRUfVjnlATdlcSUSQ6fZr3CIcwU0JQ6T75E8/g0HkfJ7 e9IA== Original-Received: by 10.68.234.36 with SMTP id ub4mr23646177pbc.68.1350149251357; Sat, 13 Oct 2012 10:27:31 -0700 (PDT) Original-Received: from debian-6.05 ([115.184.23.189]) by mx.google.com with ESMTPS id n7sm6233726pav.26.2012.10.13.10.27.28 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 13 Oct 2012 10:27:30 -0700 (PDT) In-Reply-To: <87vceez7ib.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 13 Oct 2012 19:10:00 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65566 Archived-At: Juri Linkov writes: >> Have you tried the patches? > > I'm trying your patches now, thanks. My initial reaction was to using > a symbol regexp "\\_<%s\\_>" in `read-regexp' to match a symbol at point. > I think such symbol specific defaults could be specified by callers of > `read-regexp' in its argument `DEFAULTS'. (This is not a response to your post, but only to record my observations for further consideration by the reviewer) 1. Highlighting (M-shr) can happen via isearch or through hi-lock mode (C-xwh). I don't use isearch much. So the patch merely formalizes what I had in my .emacs and it is done with my hi-lock mode glasses. 2. In `read-regexp' there is a `find-tag-default-function' but no `find-tag-regexp-function'. i.e., `find-tag-default' returns a symbol at point. But using `regexp-quote' on the result is a poor choice when in should actually be returning a symbol regexp. (When I am renaming symbols, I highlight them and then re-name. In that case, the looser regexp is unreliable and annoying. As you may very well agree, it is not uncommon to have variables share a common prefix.) 3. `read-regexp' will use tag at point as the default regexp. If a caller - say a `highlight-symbol' function or a symbol yank from isearch context - then it is the responsibility of the caller to provide the right regexp.