From: Jambunathan K <kjambunathan@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 11131@debbugs.gnu.org
Subject: bug#11131: 24.0.94; Apropos bookmarks
Date: Sat, 27 Oct 2012 01:41:59 +0530 [thread overview]
Message-ID: <87objphu28.fsf@gmail.com> (raw)
In-Reply-To: <jwvzk39w3ne.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 26 Oct 2012 13:35:40 -0400")
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Since my bookmarks are function names, substring completion is what I
>> desire. (Many functions share the *same* prefix)
>
> I haven't changed the default, but I have added a `category' of
> `bookmark', so you can use substring completion simply by customizing
> completion-category-overrides.
Thanks for this patch.
Good news:
I can confirm that `substring' for `bookmark' category works.
(custom-set-variables
'(completion-category-overrides
(quote ((buffer (styles basic substring))
(bookmark (styles substring))))))
Bad news:
`icomplete-mode' never kicks in for `C-x r b' (even with default
setting of `completion-category-overrides'). Once I reverse your
changes icomplete-mode kicks in.
$ bzr merge . -r 110680..110679
Something is surely amiss.
Request:
Following patch advertizes new category.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bug11131.diff --]
[-- Type: text/x-diff, Size: 837 bytes --]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-10-26 18:01:30 +0000
+++ lisp/ChangeLog 2012-10-26 20:02:27 +0000
@@ -1,3 +1,8 @@
+2012-10-26 Jambunathan K <kjambunathan@gmail.com>
+
+ * minibuffer.el (completion-category-overrides): New completion
+ category `bookmark' (bug#11131).
+
2012-10-26 Stefan Monnier <monnier@iro.umontreal.ca>
* emacs-lisp/advice.el (ad-assemble-advised-definition):
=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el 2012-10-25 12:56:13 +0000
+++ lisp/minibuffer.el 2012-10-26 19:58:22 +0000
@@ -743,6 +743,7 @@
(const buffer)
(const file)
(const unicode-name)
+ (const bookmark)
symbol)
:value-type
(set :tag "Properties to override"
next prev parent reply other threads:[~2012-10-26 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 8:26 bug#11131: 24.0.94; Apropos bookmarks Jambunathan K
2012-03-30 12:45 ` Stefan Monnier
2012-09-11 8:11 ` Jambunathan K
2012-09-11 13:18 ` Stefan Monnier
2012-09-11 16:52 ` Jambunathan K
2012-09-11 18:04 ` Stefan Monnier
2012-09-11 19:29 ` Juri Linkov
2012-10-26 17:35 ` Stefan Monnier
2012-10-26 20:11 ` Jambunathan K [this message]
2012-10-26 20:45 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87objphu28.fsf@gmail.com \
--to=kjambunathan@gmail.com \
--cc=11131@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.