* bug#6326: 23.1.95; `vc-diff' sometimes reports wrong diff status
@ 2010-06-02 3:11 Markus Triska
2010-06-02 9:42 ` Dan Nicolaescu
0 siblings, 1 reply; 3+ messages in thread
From: Markus Triska @ 2010-06-02 3:11 UTC (permalink / raw
To: 6326
When I open (in emacs -Q) a file under "git" version control and:
1) view its log with: C-x v l
2) open any previous revision, for example: n n n f
3) save the previous revision under a different name:
C-x C-w difrev.txt RET
4) on difrev.txt, run `vc-diff' with: C-x v =
it unexpectedly says: "No changes between working revision and
workfile". It SHOULD say that the file is NOT under version control.
Also other operations like C-x v l should say this but currently don't
(C-x v l instead unexpectedly displays the log of the original file).
In GNU Emacs 23.1.95.5 (i386-apple-darwin8.11.1, X toolkit, Xaw3d scroll bars)
of 2010-04-10 on mt-computer.lan
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure '--with-x-toolkit=lucid''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_GB.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: nil
default enable-multibyte-characters: t
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#6326: 23.1.95; `vc-diff' sometimes reports wrong diff status
2010-06-02 3:11 bug#6326: 23.1.95; `vc-diff' sometimes reports wrong diff status Markus Triska
@ 2010-06-02 9:42 ` Dan Nicolaescu
2012-10-29 11:13 ` Chong Yidong
0 siblings, 1 reply; 3+ messages in thread
From: Dan Nicolaescu @ 2010-06-02 9:42 UTC (permalink / raw
To: Markus Triska; +Cc: 6326
Markus Triska <markus.triska@gmx.at> writes:
> When I open (in emacs -Q) a file under "git" version control and:
>
> 1) view its log with: C-x v l
> 2) open any previous revision, for example: n n n f
> 3) save the previous revision under a different name:
> C-x C-w difrev.txt RET
> 4) on difrev.txt, run `vc-diff' with: C-x v =
>
> it unexpectedly says: "No changes between working revision and
> workfile". It SHOULD say that the file is NOT under version control.
> Also other operations like C-x v l should say this but currently don't
> (C-x v l instead unexpectedly displays the log of the original file).
This because `vc-parent-file' still points to the original file.
Maybe `vc-file-clearprops' (called from `write-file') should also reset `vc-parent-file'.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#6326: 23.1.95; `vc-diff' sometimes reports wrong diff status
2010-06-02 9:42 ` Dan Nicolaescu
@ 2012-10-29 11:13 ` Chong Yidong
0 siblings, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2012-10-29 11:13 UTC (permalink / raw
To: Dan Nicolaescu; +Cc: 6326, Markus Triska
Dan Nicolaescu <dann@gnu.org> writes:
>> When I open (in emacs -Q) a file under "git" version control and:
>>
>> 1) view its log with: C-x v l
>> 2) open any previous revision, for example: n n n f
>> 3) save the previous revision under a different name:
>> C-x C-w difrev.txt RET
>> 4) on difrev.txt, run `vc-diff' with: C-x v =
>>
>> it unexpectedly says: "No changes between working revision and
>> workfile". It SHOULD say that the file is NOT under version control.
>> Also other operations like C-x v l should say this but currently don't
>> (C-x v l instead unexpectedly displays the log of the original file).
>
> This because `vc-parent-file' still points to the original file.
> Maybe `vc-file-clearprops' (called from `write-file') should also
> reset `vc-parent-file'.
I think you're right. Done in trunk.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-29 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-02 3:11 bug#6326: 23.1.95; `vc-diff' sometimes reports wrong diff status Markus Triska
2010-06-02 9:42 ` Dan Nicolaescu
2012-10-29 11:13 ` Chong Yidong
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.