From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: jca+emacs@wxcvbn.org (=?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges-Ang?= =?utf-8?Q?las?=) Newsgroups: gmane.emacs.devel Subject: Re: emacs-24.2.93 build problems Date: Tue, 05 Mar 2013 15:00:27 +0100 Message-ID: <87obeyeykk.fsf@moo.wxcvbn.org> References: <513294CE.5060101@cs.ucla.edu> <87a9qi687k.fsf@moo.wxcvbn.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1362492048 7295 80.91.229.3 (5 Mar 2013 14:00:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Mar 2013 14:00:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 05 15:01:12 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UCsQV-0006lp-8n for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2013 15:01:07 +0100 Original-Received: from localhost ([::1]:45975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCsQ9-0006eU-GC for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2013 09:00:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCsQ0-0006dy-KV for emacs-devel@gnu.org; Tue, 05 Mar 2013 09:00:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCsPx-00012a-Uw for emacs-devel@gnu.org; Tue, 05 Mar 2013 09:00:36 -0500 Original-Received: from chomsky.autogeree.net ([91.216.110.36]:53101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCsPx-00011z-MZ; Tue, 05 Mar 2013 09:00:33 -0500 Mail-Followup-To: Glenn Morris , emacs-devel@gnu.org In-Reply-To: (Glenn Morris's message of "Mon, 04 Mar 2013 22:47:41 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.93 (berkeley-unix) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.216.110.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157527 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Glenn Morris writes: > J=C3=A9r=C3=A9mie Courr=C3=A8ges-Anglas wrote: > >> I have no idea whether it is correct, but M-: (list-system-processes) >> returns nil here on OpenBSD-current (5.3). > > Too late to make it work for 24.3, but could you make a bug report about > this please? Fine, I think I have a diff to make it work on all OpenBSD systems, that could be included in the trunk, I just need to test it. But as far as 24.3 is concerned, I *really* suggest making this function a stub on OpenBSD (just returning Qnil). Here's why: There are two different APIs involved: =2D old KERN_PROC, similar to NetBSD =2D new KERN_PROC, completely different Here's how they have evolved: 1. old KERN_PROC API present and visible (usable) sysctl.h rev 1.1.1.1 (1995/10/18) -> rev 1.67 (2003/12/23) 2. new KERN_PROC API added as KERN_PROC2, old KERN_PROC still available sysctl.h rev 1.68 (2004/01/07) -> rev 1.100 (2009/06/15) 3. old KERN_PROC becomes hidden behind #ifdef's sysctl rev 1.101 (2010/01/10) -> rev 1.108 (2011/03/07) 4. old KERN_PROC is removed, the new KERN_PROC replaces it, KERN_PROC2 aliases still present for backward compat sysctl.h rev 1.109 (2011/03/12) -> rev 1.119 (2011/12/14) 5. KERN_PROC2 aliases removed, only the new API remains sysctl.h rev 1.120 (2012/01/07) -> now I've done some _light_ testing and here are the results: =2D with or without the patch adding fallback to KERN_PROC2, build fails for cases 1 and 2. (This is because p_pid field wasn't present in struct kinfo_proc at that time.) =2D with the patch, build doesn't fail for case 3 =2D with the patch, cases 3, 4 and 5 will have list-system-processes returning nil, since sysctl() is called with a wrong mib. So supporting list-system-processes (as-is) on OpenBSD for 24.3 leads to build failing with 1995/10/18 < OpenBSD < 2010/01/10 and to a useless (and potentially harmful) function with OpenBSD >=3D 2010/01/10. PS: I did not and I will not investigate the case of MirOS. =2D-=20 J=C3=A9r=C3=A9mie Courr=C3=A8ges-Anglas GPG Key fingerprint: 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494 --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (OpenBSD) iQIcBAEBCgAGBQJRNfp7AAoJEGGRj78GoRSUjFwP/37+4NfnX+y2eLDag4Hntdog o61O4GD3WzTuAn0iKEmTcuzLYam/k8QpW8HfXWTxcvXJ3y5Ar5V6zdUM5glkG/a4 vDd/vr0fKtwBb6e9d5JzHVSKxRQYgx81HhCqPuDZ6WmlUvLaKuabHQmTYeKgg4Q5 GNC84ms/IgCC8qR4wkJNfxZNp4ExSJjL55QrZzgh2SJUZzqerfdgBndbgfBMRUL5 gL4gfMWbJ/BWep/rzhd54cp41ZKksIQPJH89j1mvWTAI6HIt8OSEXCbtcPPvhQ8v W/ZU2dwN6HmcYWavxvEvdxU9WxssStO8ugIXhyfkLl/qXbgKv8l5Jx6ECeYpo8qv WLkWTDkal74VwmW42HYaiigOyeKenl+M06MEOHVvL2B/C5YjrVoKLgB7EIm4ZC8h h6wF2/IBUAIhsDn5gKk0oxs+pYFGcsVccX8Vd2wbLKP6+ZKwWxDeDUT2ZMuDEnfa K9AMrHo338/ulrkz2nt+kb0FCyg7T+ZPwqCMOSk7f4Q7ukIY78WzpF7T3igzJBuv JtzByIFSgmXaavPVsXMH9c/Vuj6fP4vRoBFZ74tIyrL6vJiiSXy8SG2O8dHoF7ZX 4xrZU6UjdDbAoJsmlQSfTPNDwkVB5i7IN3FoE5BLu4s9LwZMGyqPVJz2JKYs2vSH mCVUYVyX7t3Upp/980J5 =Mc8C -----END PGP SIGNATURE----- --=-=-=--