From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests! Date: Tue, 12 Mar 2013 16:03:05 +0400 Message-ID: <87obeog70m.fsf@yandex.ru> References: <87mwu9l6ju.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1363089814 27968 80.91.229.3 (12 Mar 2013 12:03:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Mar 2013 12:03:34 +0000 (UTC) Cc: Daniel Hackney , Emacs development discussions To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 13:03:57 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFNvv-0002u1-Vj for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 13:03:56 +0100 Original-Received: from localhost ([::1]:57156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFNvZ-0005MA-KI for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 08:03:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFNvK-00054r-80 for emacs-devel@gnu.org; Tue, 12 Mar 2013 08:03:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFNvA-0007q6-3t for emacs-devel@gnu.org; Tue, 12 Mar 2013 08:03:18 -0400 Original-Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:63830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFNv9-0007pD-Sq for emacs-devel@gnu.org; Tue, 12 Mar 2013 08:03:08 -0400 Original-Received: by mail-la0-f43.google.com with SMTP id ek20so5104532lab.30 for ; Tue, 12 Mar 2013 05:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type:x-antivirus :x-antivirus-status; bh=T2Rg+OekvdeGIXHeKF7IchC4LTV3kKSXNZLqbe890SY=; b=pW2gYJy9qOkyHutVapmDkkCv+wAYbG3HCkb6grYmEgNU9puM1aQKdb51tkA4jpYXMI hfRV41dW5mor5gtJlkdSTX/GQwZpxo5YWNxvVYGHuhcGtvwGV2rLF9mXSIKJeTwCUmZH RSkOpAQ3OgNYLTt62so70Gx+6D3PWG/8rTIYtbJECNDaSW+u4uEtyofTJuUBMDauHHST 3tntM84AeF7Ozl4ft0LbVN1zGdGwe8V9EGTvOxsCKWQP/A4SBLwXJIG3JBZwbDcnr2sb rOUkywt6LgvRtI0zEmXNHSTBM1r6ctof2o1tOttf25IY+qRhdusMj4nPRE5qmZ4a/C3x f/Hw== X-Received: by 10.112.84.164 with SMTP id a4mr5921099lbz.10.1363089786678; Tue, 12 Mar 2013 05:03:06 -0700 (PDT) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPS id ev7sm5616577lbb.15.2013.03.12.05.03.05 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 12 Mar 2013 05:03:05 -0700 (PDT) In-Reply-To: <87mwu9l6ju.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 11 Mar 2013 20:01:57 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-Antivirus: avast! (VPS 130312-0, 12.03.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157770 Archived-At: Tom Tromey writes: > Daniel> The changes touch most of the code, but the overall structure of the > Daniel> code has not changed significantly. Some parts of the code which were > Daniel> questionable in the first place (such as using `tar-mode' to extract tar > Daniel> archives) have been replaced with simpler alternatives. In the case of > Daniel> tar, the file is simply downloaded to a temporary directory and > Daniel> extracted using "tar xaf foo-1.2.3.tar". > > This sounds worse to me, since it means that now package installation > has an external dependency. Previously this was not the case -- > intentionally. Indeed, if that means that it won't work on vanilla Windows installations, then this decision should be reversed. The change looks good otherwise, I especially like the presence of tests.