Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more.

Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more.

[Dmitry Gutov]

Stefan Monnier <monnier@iro.umontreal.ca> writes:
> ------------------------------------------------------------
> revno: 112980
> revision-id: monnier@iro.umontreal.ca-20130614032018-uowzljhh6kbvcp4i
> parent: monnier@iro.umontreal.ca-20130614023128-iedxmujzz2ss1bwe
> committer: Stefan Monnier <monnier@iro.umontreal.ca>
> branch nick: trunk
> timestamp: Thu 2013-06-13 23:20:18 -0400
...
> +(defun package-load-descriptor (pkg-dir)
> +  "Load the description file in directory PKG-DIR."
> +  (let ((pkg-file (expand-file-name (package--description-file pkg-dir)
> +                                    pkg-dir)))
> +    (when (file-exists-p pkg-file)
> +      (with-temp-buffer
> +        (insert-file-contents pkg-file)
> +        (emacs-lisp-mode)

Is using emacs-lisp-mode here necessary?

It breaks my configuration, because I have `paredit-mode' in
`emacs-lisp-mode-hook', and it's installed via ELPA, and so when this
function is called for the first time (at least), Paredit is not yet in
`load-path'.

Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more.

[Stefan Monnier]

> Is using emacs-lisp-mode here necessary?

No.  Can you make it a bug-report, please (or install a patch which
just makes it use the emacs-lisp-mode syntax-table, since that's all
that matters)?


        Stefan

Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more.

[Dmitry Gutov]

On 17.06.2013 3:19, Stefan Monnier wrote:
>> Is using emacs-lisp-mode here necessary?
>
> No.  Can you make it a bug-report, please (or install a patch which
> just makes it use the emacs-lisp-mode syntax-table, since that's all
> that matters)?

Sure, installed.

Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more.

[Stefan Monnier]

>>> Is using emacs-lisp-mode here necessary?
>> No.  Can you make it a bug-report, please (or install a patch which
>> just makes it use the emacs-lisp-mode syntax-table, since that's all
>> that matters)?
> Sure, installed.

Actually, that was silly: since the code just uses `read' it doesn't
even need the syntax table (all this is because of some earlier code
I used which did need the syntax-table, and I didn't update my brain
according to the new code).


        Stefan

Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more.

[Dmitry Gutov]

On 17.06.2013 18:32, Stefan Monnier wrote:
>>>> Is using emacs-lisp-mode here necessary?
>>> No.  Can you make it a bug-report, please (or install a patch which
>>> just makes it use the emacs-lisp-mode syntax-table, since that's all
>>> that matters)?
>> Sure, installed.
>
> Actually, that was silly: since the code just uses `read' it doesn't
> even need the syntax table (all this is because of some earlier code
> I used which did need the syntax-table, and I didn't update my brain
> according to the new code).

That makes sense. Initially, I just commented emacs-lisp-mode call out, 
and the function worked fine, but I figured there could be some edge 
cases, etc.