From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer' Date: Sun, 09 Feb 2014 19:21:54 -0800 Message-ID: <87ob2fhctp.fsf@building.gnus.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1392002648 29476 80.91.229.3 (10 Feb 2014 03:24:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Feb 2014 03:24:08 +0000 (UTC) Cc: 6259@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 10 04:24:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WChTk-00034I-1s for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Feb 2014 04:24:16 +0100 Original-Received: from localhost ([::1]:53106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WChTj-00058P-K3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Feb 2014 22:24:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WChTb-00058I-8K for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2014 22:24:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WChTW-0003kl-91 for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2014 22:24:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WChTW-0003kh-5l for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2014 22:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WChTV-0005CF-SQ for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2014 22:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2014 03:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6259 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6259-submit@debbugs.gnu.org id=B6259.139200260719913 (code B ref 6259); Mon, 10 Feb 2014 03:24:01 +0000 Original-Received: (at 6259) by debbugs.gnu.org; 10 Feb 2014 03:23:27 +0000 Original-Received: from localhost ([127.0.0.1]:33144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WChSw-0005B7-Bx for submit@debbugs.gnu.org; Sun, 09 Feb 2014 22:23:26 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:51470) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WChSu-0005Ay-8P for 6259@debbugs.gnu.org; Sun, 09 Feb 2014 22:23:24 -0500 Original-Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WChSd-00052A-HL; Mon, 10 Feb 2014 04:23:07 +0100 In-Reply-To: (Drew Adams's message of "Mon, 24 May 2010 10:03:04 -0700") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1WChSd-00052A-HL MailScanner-NULL-Check: 1392607388.28244@wYIACghsUcMjhd+2SEBVVQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85153 Archived-At: "Drew Adams" writes: > 1. I thought that distributed Emacs code was not supposed to use > `defadvice'. `uniquify.el' uses it. > > 2. That advice makes the doc for `create-file-buffer' incorrect: > > emacs -Q > > C-h f create-file-buffer RET > > There is nothing about the function being advised. And since uniquify is the default now, it should probably be fixed: -------- create-file-buffer is a compiled Lisp function in `files.el'. (create-file-buffer ARG1) :around advice: `uniquify--create-file-buffer-advice' -------- -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/