all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 6259@debbugs.gnu.org
Subject: bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer'
Date: Sun, 09 Feb 2014 19:21:54 -0800	[thread overview]
Message-ID: <87ob2fhctp.fsf@building.gnus.org> (raw)
In-Reply-To: <ABE67992A78B4A9DB0E496E19C82B6BC@us.oracle.com> (Drew Adams's message of "Mon, 24 May 2010 10:03:04 -0700")

"Drew Adams" <drew.adams@oracle.com> writes:

> 1. I thought that distributed Emacs code was not supposed to use
> `defadvice'.  `uniquify.el' uses it.
>
> 2. That advice makes the doc for `create-file-buffer' incorrect:
>
> emacs -Q
>
> C-h f create-file-buffer RET
>
> There is nothing about the function being advised.

And since uniquify is the default now, it should probably be fixed:

--------

create-file-buffer is a compiled Lisp function in `files.el'.

(create-file-buffer ARG1)

:around advice: `uniquify--create-file-buffer-advice'

--------


-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





  reply	other threads:[~2014-02-10  3:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 17:03 bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer' Drew Adams
2014-02-10  3:21 ` Lars Ingebrigtsen [this message]
2016-05-01 17:53   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ob2fhctp.fsf@building.gnus.org \
    --to=larsi@gnus.org \
    --cc=6259@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.