From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree Date: Fri, 21 Nov 2014 11:32:20 +0100 Message-ID: <87oas0n8sr.fsf@rosalinde.fritz.box> References: <87lhn7s522.fsf@rosalinde.fritz.box> <83lhn789tq.fsf@gnu.org> <87h9xvruan.fsf@rosalinde.fritz.box> <83tx1v6mur.fsf@gnu.org> <87a93nrlql.fsf@rosalinde.fritz.box> <83lhn76iex.fsf@gnu.org> <8761easv3s.fsf@rosalinde.fritz.box> <87r3wytcaa.fsf@rosalinde.fritz.box> <83vbm96dxs.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416566005 10523 80.91.229.3 (21 Nov 2014 10:33:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2014 10:33:25 +0000 (UTC) Cc: paul@tilk.co, 19102@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 21 11:33:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrlWf-0006gv-Oo for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 11:33:17 +0100 Original-Received: from localhost ([::1]:39884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrlWf-0005LI-Bu for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 05:33:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrlWW-0005L6-W2 for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 05:33:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrlWR-0006yI-1X for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 05:33:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrlWQ-0006yD-VT for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 05:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XrlWQ-0004dn-E1 for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 05:33:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Nov 2014 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19102-submit@debbugs.gnu.org id=B19102.141656595317767 (code B ref 19102); Fri, 21 Nov 2014 10:33:02 +0000 Original-Received: (at 19102) by debbugs.gnu.org; 21 Nov 2014 10:32:33 +0000 Original-Received: from localhost ([127.0.0.1]:40296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrlVx-0004cV-0L for submit@debbugs.gnu.org; Fri, 21 Nov 2014 05:32:33 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:62784) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrlVt-0004cH-AR for 19102@debbugs.gnu.org; Fri, 21 Nov 2014 05:32:30 -0500 Original-Received: from rosalinde.fritz.box ([89.245.122.145]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MIuft-1XpIfk2s13-002YhK; Fri, 21 Nov 2014 11:32:21 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:h9A6zX8Qfrj38gHIcZknjR86404dOEOVxgATAATjwdS2NOPjHlV rqN0zP1ghf50OyjHjZAtDyLoXQQR0FzsFhtnQpFOZ+2zKtoCK9Aw9jNL515YftKGQbfxBQi BwuQf8vmkmfsYQAf07QF6beX1mVoAMwTn0EMWJCoNrV1wr/q22rmfhLEAPvb5zWOQNeKzCY a9UNipSMR/v5wfP8VVfcQ== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96366 On Thu, 20 Nov 2014 18:21:03 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: Eli Zaretskii , 19102@debbugs.gnu.org >> Date: Thu, 20 Nov 2014 11:08:13 +0100 >> >> outline-move-subtree-up/down works if there's an empty line after >> the last subtree, but if not, it puts the last two subtree headers >> on the same line. > > Does it make sense to fix outline-move-subtree-up/down so that they > also work when there's no empty line after the last subtree? That's It didn't occur to me before, but your question prompted me to check and I see outline-mode derives from text-mode, which sets require-final-newline to mode-require-final-newline, so I guess the assumption is indeed that files in outline-mode should end in a newline. > one thing that looks inelegant in your patch, and might also cause > some (minor) trouble: what if the user types C-g before this function > finishes? We could avoid the trouble by wrapping the newline call in unwind-protect, couldn't we? But can C-g really take effect here? There is no place in the function where execution halts to wait for user feedback. Maybe with an outline containing an enormous number of subtrees the calculations could take long enough to make C-g interrupt it, though I tried and failed to do it moving over 500 subtrees. But I guess those are idle speculations, it does seem that just keeping a final newline added by the function is the simplest (and perhaps best) fix, so I guess we should commit some version of that fix and see if anyone complains. Steve Berman