From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: fgallina@gnu.org (=?UTF-8?Q?Fabi=C3=A1n?= Ezequiel Gallina) Newsgroups: gmane.emacs.bugs Subject: bug#19691: Date: Wed, 04 Feb 2015 19:56:29 -0300 Message-ID: <87oap9nv4y.fsf@gnu.org> References: <87vbjt4o1d.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1423090629 28876 80.91.229.3 (4 Feb 2015 22:57:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2015 22:57:09 +0000 (UTC) Cc: 19691@debbugs.gnu.org, Fabian Ezequiel Gallina To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 04 23:57:09 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJ8se-0006dU-Ap for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2015 23:57:08 +0100 Original-Received: from localhost ([::1]:39263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ8sd-0004IS-Ut for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2015 17:57:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ8sZ-0004GB-67 for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 17:57:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ8sY-0005q4-At for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 17:57:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ8sY-0005pt-8o for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 17:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YJ8sY-0007yA-0s for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 17:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: fgallina@gnu.org (=?UTF-8?Q?Fabi=C3=A1n?= Ezequiel Gallina) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Feb 2015 22:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug patch Original-Received: via spool by 19691-submit@debbugs.gnu.org id=B19691.142309059630601 (code B ref 19691); Wed, 04 Feb 2015 22:57:01 +0000 Original-Received: (at 19691) by debbugs.gnu.org; 4 Feb 2015 22:56:36 +0000 Original-Received: from localhost ([127.0.0.1]:34370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJ8s7-0007xV-SP for submit@debbugs.gnu.org; Wed, 04 Feb 2015 17:56:36 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:59310 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJ8s6-0007xN-2q for 19691@debbugs.gnu.org; Wed, 04 Feb 2015 17:56:34 -0500 Original-Received: from [190.246.172.180] (port=52812 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YJ8s4-0006Tk-Uw; Wed, 04 Feb 2015 17:56:33 -0500 In-Reply-To: (Carlos Pita's message of "Mon, 2 Feb 2015 17:28:12 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99048 Archived-At: Carlos Pita writes: > Here is a patch updated against current master. > > I know you have closed this issue, but please reconsider it in the > light of my new proposal: it's very simple and PEP 8 friendly. > > The implementation just set a :no-indent context after two or more > consecutive blank lines. That's it. > > PEP 8 states: Separate top-level function and class definitions with > two blank lines. > > This is not mandatory, of course, but it's often the real intention of > the coder and, in any case, it promotes honoring basic conventions. Hi Carlos, I do like this idea. I'd accept your patch right away but I'd like to differentiate the case with a special keyword (e.g. :after-blank-lines). Also I want some tests. BTW, I'm quite happy you are getting into the internals and started submitting patches. If you plan to work on python.el (or any other part of Emacs) you'll need to sign the copyright assignment (if you haven't) for non trivial changes. I would recommend you to start the process to do so, not because this patch is not trivial enough, but because you have few other patches in the queue that may be useful. PS: I haven't forgot about your other reports but I'm not finding time to work on python.el yet, but know they are under my radar. Regards, Fabi=C3=A1n.