all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: fgallina@gnu.org (Fabián Ezequiel Gallina)
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 19691@debbugs.gnu.org, Fabian Ezequiel Gallina <galli.87@gmail.com>
Subject: bug#19691:
Date: Wed, 04 Feb 2015 19:56:29 -0300	[thread overview]
Message-ID: <87oap9nv4y.fsf@gnu.org> (raw)
In-Reply-To: <CAELgYhd4bvttQ_9bkqX90muN_1GSTR6=C08vnQJv_AUtWutY4w@mail.gmail.com> (Carlos Pita's message of "Mon, 2 Feb 2015 17:28:12 -0300")

Carlos Pita <carlosjosepita@gmail.com> writes:

> Here is a patch updated against current master.
>
> I know you have closed this issue, but please reconsider it in the
> light of my new proposal: it's very simple and PEP 8 friendly.
>
> The implementation just set a :no-indent context after two or more
> consecutive blank lines. That's it.
>
> PEP 8 states: Separate top-level function and class definitions with
> two blank lines.
>
> This is not mandatory, of course, but it's often the real intention of
> the coder and, in any case, it promotes honoring basic conventions.


Hi Carlos,

I do like this idea.  I'd accept your patch right away but I'd like to
differentiate the case with a special keyword (e.g. :after-blank-lines).
Also I want some tests.

BTW, I'm quite happy you are getting into the internals and started
submitting patches.  If you plan to work on python.el (or any other part
of Emacs) you'll need to sign the copyright assignment (if you haven't)
for non trivial changes.  I would recommend you to start the process to
do so, not because this patch is not trivial enough, but because you
have few other patches in the queue that may be useful.


PS: I haven't forgot about your other reports but I'm not finding time
to work on python.el yet, but know they are under my radar.



Regards,
Fabián.





      reply	other threads:[~2015-02-04 22:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 14:25 bug#19691: 24.4; python.el: indentation RFE Carlos Pita
2015-01-30  3:52 ` Fabián Ezequiel Gallina
     [not found] ` <handler.19691.D19691.14225899572400.notifdone@debbugs.gnu.org>
2015-01-30 10:18   ` bug#19691: closed (24.4; python.el: indentation RFE) Carlos Pita
2015-02-02 20:28 ` bug#19691: Carlos Pita
2015-02-04 22:56   ` Fabián Ezequiel Gallina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oap9nv4y.fsf@gnu.org \
    --to=fgallina@gnu.org \
    --cc=19691@debbugs.gnu.org \
    --cc=carlosjosepita@gmail.com \
    --cc=galli.87@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.