From: Juri Linkov <juri@linkov.net>
To: 20785@debbugs.gnu.org
Subject: bug#20785: user-error for mark-inactive
Date: Thu, 11 Jun 2015 02:34:06 +0300 [thread overview]
Message-ID: <87oakncf4h.fsf@mail.linkov.net> (raw)
A single remaining case that is too annoying is when the debugger is
called due to a user error while accidentally typing `C-w' (kill-region)
when there is no active mark in the buffer:
Debugger entered--Lisp error: (mark-inactive)
signal(mark-inactive nil)
mark()
byte-code("\300 `\301E\207" [mark region] 3)
call-interactively(kill-region nil nil)
command-execute(kill-region)
The following patch avoids this in both cases:
1. when mark-even-if-inactive is non-nil, displays the message:
"user-error: The mark is not set now, so there is no region"
2. when mark-even-if-inactive is nil, displays the message:
"mark: The mark is not active now"
diff --git a/lisp/simple.el b/lisp/simple.el
index 1eb0643..31810a4 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -4017,7 +4021,7 @@ (defun kill-region (beg end &optional region)
;; calling `kill-append'.
(interactive (list (mark) (point) 'region))
(unless (and beg end)
- (error "The mark is not set now, so there is no region"))
+ (user-error "The mark is not set now, so there is no region"))
(condition-case nil
(let ((string (if region
(funcall region-extract-function 'delete)
diff --git a/lisp/bindings.el b/lisp/bindings.el
index b658914..3672812 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -633,7 +633,7 @@ (setq debug-ignored-errors
;; file-supersession should all be user-errors!
`(beginning-of-line beginning-of-buffer end-of-line
end-of-buffer end-of-file buffer-read-only
- file-supersession
+ file-supersession mark-inactive
user-error ;; That's the main one!
))
next reply other threads:[~2015-06-10 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 23:34 Juri Linkov [this message]
2015-06-11 3:11 ` bug#20785: user-error for mark-inactive Stefan Monnier
2015-06-11 23:17 ` Juri Linkov
2015-06-12 5:40 ` Stefan Monnier
2015-06-22 22:46 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oakncf4h.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=20785@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.