current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch"

current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch"

[Robert Klein]

Hi,

when I export a file with current org main I get the following error
(git-bisect-identified commit below):


Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  file-exists-p(nil)
  org-check-agenda-file(nil)
  byte-code("\306\b!\203\f......   [can't paste]   .b\207" [file pos
org-agenda-ignore-properties org-todo-keywords-for-agenda
org-todo-keywords-1 org-done-keywords-for-agenda bufferp
org-check-agenda-file org-get-agenda-file-buffer
org-set-regexps-and-options tags-only category
org-refresh-category-properties stats org-refresh-stats-properties
effort org-refresh-effort-properties appt org-refresh-properties
"APPT_WARNTIME" org-appt-warntime append copy-sequence delete-dups
org-uniquify-alist buffer-modified-p t nil ((byte-code "...." [modified
restore-buffer-modified-p nil] 2)) remove-text-properties
re-search-forward org-at-heading-p add-text-properties point-at-bol
org-end-of-subtree format "^\\* .*\\<%s\\>" match-data ((byte-code
"..." [save-match-data-internal set-match-data evaporate] 3))
org-in-commented-heading-p 0 org-done-keywords
org-todo-keyword-alist-for-agenda org-todo-key-alist
org-tag-alist-for-agenda org-tag-alist org-tag-persistent-alist list
res org-group-tags ...] 5)
 org-agenda-prepare-buffers((nil))
  org-map-entries(#[nil "\300\301 !\207" [org-reduced-level
 org-current-level] 2])
 org-export--prepare-file-contents("/home/theorie/kleinrob/Documents/mpipdocs/sysdoc/include/mpip-akte.org"
 nil 0 1 1 #s(hash-table size 65 test equal rehash-size 1.5
 rehash-threshold 0.8 data ( ...))) org-export-expand-include-keyword()
 org-export-as(latex nil nil nil (:output-file "./nmrfiler.tex"))
 org-export-to-file(latex "./nmrfiler.tex" nil nil nil nil nil #[(file)
 "\301\b!\207" [file org-latex-compile] 2]) org-latex-export-to-pdf(nil
 nil nil nil) org-export-dispatch(nil)
 call-interactively(org-export-dispatch nil nil)
 command-execute(org-export-dispatch)

it worked on friday morning; git bisect identifiesd the following
commit:

 git bisect bad
ef9637030456b153fd834f4c9202a9264d5ef18d is the first bad commit
commit ef9637030456b153fd834f4c9202a9264d5ef18d
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Sat Aug 8 19:41:57 2015 -0400

    Backport commit 3a5f751 from Emacs master branch
    
    * lisp/org.el (org-goto-map, org-assign-fast-keys)
    (org-contextualize-keys, org-contextualize-validate-key)
    (org-notes-order-reversed-p, org-local-logging, org-map-entries)
    (org-find-olp, org-find-exact-heading-in-directory)
    (org-cycle-agenda-files, org-release-buffers, org-fill-template)
    (org-agenda-prepare-buffers, org-occur-in-agenda-files)
    (org-replace-escapes): Use dolist.
    (org-mode): Optimize away XEmacs-only code.
    (org-refile-get-targets): Remove unused var `f'.
    (org-fast-todo-selection): Remove unused var `e'.
    (org-make-tags-matcher): Use dolist.  Remove unused var `term'.
    (org-fast-tag-selection): Use dolist.  Remove unused var `e'.
    (org-format-latex): Use dolist.  Remove unused var `e'.
    (org-backward-sentence, org-forward-sentence, org-meta-return)
    (org-kill-line): Mark arg as unused.
    (org-submit-bug-report): Silence compiler warning.
    (org-occur-in-agenda-files): Don't use add-to-list on local vars.
    (org-get-cursor-date): Remove unused var `tm'.
    (org-comment-or-uncomment-region): Use standard name `_'.
    (reftex-docstruct-symbol, reftex-cite-format): Declare to
    silence byte-compiler.
    (org-reftex-citation): Add `org--' prefix to dynamically scoped
    `rds' var.
    
    org.el: Fix up some lexical scoping warnings, and use dolist
    3a5f75193ed10ee5fb458e9879340947f31d5e12
    Stefan Monnier
    Sat Aug 8 19:41:57 2015 -0400

:040000 040000 19e9e2191b96b7139dd54e2b6682783bfaabb2c4
75f021c6d8d6e92c803e0a2723cd22de5aa2c130 M	lisp


If the changes in the commit are Ok, there should perhaps be a check in
org-check-agenda-file:

(defun org-check-agenda-file (file)
  "Make sure FILE exists.  If not, ask user what to do."
  (when (not (string-p file))
      do something else...


Any help is very much apprecieated.

Thank you very much!

Best regards
Robert

Re: current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch"

[Kyle Meyer]

Robert Klein <roklein@roklein.de> wrote:
> Hi,
>
> when I export a file with current org main I get the following error
> (git-bisect-identified commit below):
[...]
>  git bisect bad
> ef9637030456b153fd834f4c9202a9264d5ef18d is the first bad commit
> commit ef9637030456b153fd834f4c9202a9264d5ef18d
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date:   Sat Aug 8 19:41:57 2015 -0400
>
>     Backport commit 3a5f751 from Emacs master branch

Thank you for the report.

> If the changes in the commit are Ok, there should perhaps be a check in
> org-check-agenda-file:
>
> (defun org-check-agenda-file (file)
>   "Make sure FILE exists.  If not, ask user what to do."
>   (when (not (string-p file))
>       do something else...

Based on the backtrace, I think this is another instance like 11e8749
("org-clock: Fix org-agenda-prepare-buffers call", 2015-08-09), where
org-agenda-prepare-buffers was being called with '(nil)' for the list of
files.

The backport changed a '(while (setq VAR (pop LIST)))' to
'(dolist (VAR LIST))', which exposes this, but '(nil)' should not be
passed as a list of files in the first place.

I'll have a closer look.

--
Kyle

Re: current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch"

[Kyle Meyer]

Kyle Meyer <kyle@kyleam.com> wrote:
[...]
> The backport changed a '(while (setq VAR (pop LIST)))' to
> '(dolist (VAR LIST))', which exposes this, but '(nil)' should not be
> passed as a list of files in the first place.

Fixed in 44c8cd7.

-- 
Kyle

Re: current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch"

[Robert Klein]

On Mon, 10 Aug 2015 12:26:00 -0400
Kyle Meyer <kyle@kyleam.com> wrote:

> Kyle Meyer <kyle@kyleam.com> wrote:
> [...]
> > The backport changed a '(while (setq VAR (pop LIST)))' to
> > '(dolist (VAR LIST))', which exposes this, but '(nil)' should not be
> > passed as a list of files in the first place.
> 
> Fixed in 44c8cd7.
> 

Confirmed.  It works again.  Thank you very much!

Best regards
Robert