From: Kyle Meyer <kyle@kyleam.com>
To: Matthew MacLean <archenoth@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby
Date: Wed, 12 Aug 2015 13:21:41 -0400 [thread overview]
Message-ID: <87oaic4e3e.fsf@kyleam.com> (raw)
In-Reply-To: <CA+GZiYrWfYBriyb3c_UbBj89cTYUaHnJ23K0A9=mT+TebJmTGg@mail.gmail.com> (Matthew MacLean's message of "Wed, 12 Aug 2015 00:18:13 -0600")
Matthew MacLean <archenoth@gmail.com> writes:
> Alright, done. Is this acceptable? (Provided that tests don't count towards
> line count, of course)
Thanks. A few minor comments on the commit message.
> Subject: [PATCH] ob-ruby: Fix double-escaping
>
> * lisp/ob-ruby.el: Remove second call to
> `org-babel-ruby-table-or-string' in `org-babel-ruby-evaluate'.
Please add the name of the changed function in parentheses after the
file name rather than putting it in the description body.
> * testing/lisp/test-ob-ruby.el: Add test to verify
> `org-babel-execute:ruby' can evaluate Ruby code. (What the
> double-escape prevented)
Same here for the test name. "Add test." for description would do.
> I removed the escaping from `org-babel-ruby-evaluate', because the only
> place `org-babel-ruby-evaluate' is ever called is in
> `org-babel-execute:ruby'.
>
> In this function, its result either escaped (Where the double escape
> previously occurred) or passed in as the "scalar-form" of
> `org-babel-result-cond', which handles the "pp" and "code" parameters.
> (A place that doesn't need escaping.)
I think the above two paragraphs could be replaced by a link to this ML
post.
Thanks for working on this.
--
Kyle
next prev parent reply other threads:[~2015-08-12 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 20:52 fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby Matthew MacLean
2015-08-11 22:33 ` Kyle Meyer
2015-08-11 22:36 ` Kyle Meyer
2015-08-11 22:46 ` Matthew MacLean
2015-08-12 0:52 ` Kyle Meyer
2015-08-12 3:24 ` Matthew MacLean
2015-08-12 5:53 ` Kyle Meyer
2015-08-12 6:18 ` Matthew MacLean
2015-08-12 17:21 ` Kyle Meyer [this message]
2015-08-12 20:05 ` Matthew MacLean
2015-08-13 3:41 ` Kyle Meyer
2015-08-13 4:02 ` Matthew MacLean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaic4e3e.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=archenoth@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.