From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21313: 25.0.50; Strange errors from dbus-handle-event Date: Wed, 16 Sep 2015 13:39:11 +0200 Message-ID: <87oah2sie8.fsf@gnu.org> References: <877foo4nkd.fsf@gnu.org> <87wpvzs4r3.fsf@gnu.org> <87bnd9cf7g.fsf@gnu.org> <831te53zbq.fsf@gnu.org> <871te5cdg7.fsf@gnu.org> <83wpvx2h16.fsf@gnu.org> <87r3lziti9.fsf@gnu.org> <83zj0n7jtl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442403630 4818 80.91.229.3 (16 Sep 2015 11:40:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Sep 2015 11:40:30 +0000 (UTC) Cc: Jan =?UTF-8?Q?Dj=C3=A4rv?= , 21313@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 16 13:40:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZcB4V-0003kN-4B for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2015 13:40:19 +0200 Original-Received: from localhost ([::1]:49638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcB4U-0004ZV-LY for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2015 07:40:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcB4K-0004VR-Og for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2015 07:40:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcB4F-0004BV-QM for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2015 07:40:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcB4F-0004BG-Mc for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2015 07:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZcB4E-0002Gy-SK for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2015 07:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Sep 2015 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21313-submit@debbugs.gnu.org id=B21313.14424035568681 (code B ref 21313); Wed, 16 Sep 2015 11:40:02 +0000 Original-Received: (at 21313) by debbugs.gnu.org; 16 Sep 2015 11:39:16 +0000 Original-Received: from localhost ([127.0.0.1]:34200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZcB3T-0002Fw-Md for submit@debbugs.gnu.org; Wed, 16 Sep 2015 07:39:15 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:56583) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZcB3Q-0002Fn-Sk for 21313@debbugs.gnu.org; Wed, 16 Sep 2015 07:39:14 -0400 Original-Received: from thinkpad-t440p (wlan-95-207.uni-koblenz.de [141.26.95.207]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 1CC2C1A8323; Wed, 16 Sep 2015 13:39:12 +0200 (CEST) In-Reply-To: <83zj0n7jtl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Sep 2015 19:01:42 +0300") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106639 Archived-At: Eli Zaretskii writes: >> From: Tassilo Horn >> Cc: 21313@debbugs.gnu.org >> Date: Tue, 15 Sep 2015 17:37:02 +0200 >> >> I wondered why channel is not removed from Available here. I mean, >> input was available, and then the handlers registered using add_read_fd >> by inotify or dbus consumed the input, so there's probably no input >> left. So I tried this patch >> >> --8<---------------cut here---------------start------------->8--- >> diff --git a/src/process.c b/src/process.c >> index ed5f4c0..7985e37 100644 >> --- a/src/process.c >> +++ b/src/process.c >> @@ -5036,7 +5036,10 @@ wait_reading_process_output (intmax_t time_limit, int nsecs, int read_kbd, >> && FD_ISSET (channel, &Available)) >> || (d->condition & FOR_WRITE >> && FD_ISSET (channel, &write_mask)))) >> - d->func (channel, d->data); >> + { >> + d->func (channel, d->data); >> + FD_CLR (channel, &Available); >> + } >> } >> >> for (channel = 0; channel <= max_process_desc; channel++) >> --8<---------------cut here---------------end--------------->8--- >> >> and since then the problem has not appeared again and I can't see any >> obvious other malfunction. But of course that's really a naive change. >> I can grasp the big picture of wait_reading_process_output but not all >> the details. > > If no one objects in a week, please push this, and let's see what it > breaks. Yes, I'll do. And I'v Cc-ed Jan in this mail because he's the original author of that code and probably knows best if that's the right thing to do. Bye, Tassilo