From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: ox-beamer and CUSTOM_ID
Date: Thu, 15 Oct 2015 21:48:30 +0200
Message-ID: <87oafz6hgx.fsf@nicolasgoaziou.fr>
References: <CAFgFV9O54WCf=_w3fGG0oujLESTN5j6bP=-RqUisRUfc-1e1OA@mail.gmail.com>
	<87pp0izi1f.fsf@nicolasgoaziou.fr>
	<CAFgFV9Nhta9VvPLU0L=nfww7Jh5nfQU178sMkWqrQVoNTKfXHA@mail.gmail.com>
	<87h9luzgyd.fsf@nicolasgoaziou.fr>
	<CAFgFV9MwZDYjNibAH+-EBMfBpNAu6KxjjkCX62PwX_Y4aU34Cg@mail.gmail.com>
	<874mhuze22.fsf@nicolasgoaziou.fr>
	<CAFgFV9MrYU8twx2BbdvMo0VSdZT7i-JPr63XgMOENMsbCr-psA@mail.gmail.com>
	<87vbaaxvia.fsf@nicolasgoaziou.fr>
	<CAFgFV9PPSLLZBhSyNJNOeyLcMS1fL7MoX0Ac7skqL350SJv_CQ@mail.gmail.com>
	<87k2qpy85j.fsf@nicolasgoaziou.fr>
	<CAFgFV9OP19OF-XdcccNZNX34BCheHXRzYBfZquOev87TrwUx3A@mail.gmail.com>
	<87wpuowmrn.fsf@nicolasgoaziou.fr>
	<CAFgFV9Mp3gT2QR=RkjKqkTY6bU0C9TotmSjkzMMqaZyzzbmisg@mail.gmail.com>
	<CAFgFV9MTnd-_PXNbWzYMz87Q8Fsj2OS3Xj388TtTGpfMrBJLhA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZmoUD-0002CA-4T
	for emacs-orgmode@gnu.org; Thu, 15 Oct 2015 15:46:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZmoUC-0007me-Bz
	for emacs-orgmode@gnu.org; Thu, 15 Oct 2015 15:46:49 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:33385)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZmoUC-0007lg-5U
	for emacs-orgmode@gnu.org; Thu, 15 Oct 2015 15:46:48 -0400
In-Reply-To: <CAFgFV9MTnd-_PXNbWzYMz87Q8Fsj2OS3Xj388TtTGpfMrBJLhA@mail.gmail.com>
	(Fabrice Popineau's message of "Thu, 15 Oct 2015 21:25:45 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Fabrice Popineau <fabrice.popineau@gmail.com> writes:

> Oh! I got it.
>
> The problem is that beamer expects braces around a label with colon when
> you setup the label
> but *not when you ref it* :
>
> \begin{frame}[label={sec:orgheadline1}]{Frame 1}
> bla bla bla bla bla bla bla bla bla bla bla bla
> \end{frame}
>
> \againframe{sec:orgheadline1}
>
> The braces at setup are required by the keyval package which is used to
> parse the options.
> However, the label is called sec:orgheadline1 and not {sec:orgheadline1}.
> But at the moment, ox-beamer outputs :
>
> \againframe{{sec:orgheadline1}}
>
> I fixed it unintentionally by using my own label without colon.
>
> So basically you need this:
>
> diff --git a/vendor/org-mode/lisp/ox-beamer.el
> b/vendor/org-mode/lisp/ox-beamer.el
> index 24dcf19..75b51df 100644
> --- a/vendor/org-mode/lisp/ox-beamer.el
> +++ b/vendor/org-mode/lisp/ox-beamer.el
> @@ -621,7 +623,7 @@ as a communication channel."
>                                      (org-export-resolve-id-link link
> info))))
>                       ;; Now use user-defined label provided in TARGET
>                       ;; headline, or fallback to standard one.
> -                     (format "{%s}" (org-beamer--get-label target
> info)))))))
> +                     (format "%s" (org-beamer--get-label target info)))))))
>         ;; Case 2: Creation of an appendix is requested.
>         ((equal environment "appendix")
>         (concat "\\appendix"

Thanks for the debugging. Do you want to provide a patch against maint
for this ? Note that your library needs to be updated.

Regards,