all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kostas Zorbadelos <kzorba@otenet.gr>
To: Jan Tatarik <jan.tatarik@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, help-gnu-emacs@gnu.org
Subject: Re: gnus-icalendar errors in emacs 24.5 [timezone issue]
Date: Tue, 23 Feb 2016 16:25:36 +0200	[thread overview]
Message-ID: <87oab7zeov.fsf_-_@otenet.gr> (raw)
In-Reply-To: <87h9gz90jb.fsf_-_@otenet.gr> (Kostas Zorbadelos's message of "Tue, 23 Feb 2016 12:35:52 +0200")

Kostas Zorbadelos <kzorba@otenet.gr> writes:

Hello,

time handling is never trivial, it seems.
When the calendar sender is in a different timezone, the extracted event
does not seem to be converted to my timezone.

I need more reading and understanding of the code to find out where the
issue is (e.g what exactly are start, end below in
(defmethod gnus-icalendar-event:org-timestamp ((event gnus-icalendar-event))
      ...
      (start (gnus-icalendar-event:start-time event))
      (end (gnus-icalendar-event:end-time event))
      ...
).

In case you have any ideas, or I am missing something, please share. 

Regards,
Kostas

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Jan Tatarik <jan.tatarik@gmail.com> writes:
>>
>>> How about this? It's a patch against the emacs-25 branch, I was not able
>>> to connect to the gnus git. 
>>
>> The Gnus git repository is now read-only (and only with anonymous
>> access).
>>
>>> diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el
>>> index 4faef06..82a649f 100644
>>> --- a/lisp/gnus/gnus-icalendar.el
>>> +++ b/lisp/gnus/gnus-icalendar.el
>>> @@ -401,8 +401,8 @@ gnus-icalendar-event:org-timestamp
>>>           (end-time (format-time-string "%H:%M" end))
>>>           (end-at-midnight (string= end-time "00:00"))
>>>           (start-end-date-diff (/ (float-time (time-subtract
>>> -                                        (date-to-time end-date)
>>> -                                        (date-to-time start-date)))
>>> +                                        (org-time-string-to-time end-date)
>>> +                                        (org-time-string-to-time start-date)))
>>
>> Yes, this seems to fix the problem.  I'll apply to emacs-25 and push.
>

--
Kostas Zorbadelos	http://gr.linkedin.com/in/kzorba	



      reply	other threads:[~2016-02-23 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.5404.1456174176.843.help-gnu-emacs@gnu.org>
2016-02-23  1:41 ` gnus-icalendar errors in emacs 24.5 Lars Magne Ingebrigtsen
2016-02-23  9:13   ` Kostas Zorbadelos
2016-02-23 10:13   ` Jan Tatarik
2016-02-23 10:16     ` Lars Ingebrigtsen
2016-02-23 10:35       ` gnus-icalendar errors in emacs 24.5 [FIXED] Kostas Zorbadelos
2016-02-23 14:25         ` Kostas Zorbadelos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oab7zeov.fsf_-_@otenet.gr \
    --to=kzorba@otenet.gr \
    --cc=help-gnu-emacs@gnu.org \
    --cc=jan.tatarik@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.