From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 16891@debbugs.gnu.org
Subject: bug#16891: 24.3; [PATCH] align-regexp now has a separate history for its interactive argument
Date: Wed, 24 Feb 2016 14:05:19 +1100 [thread overview]
Message-ID: <87oab6n6z4.fsf@gnus.org> (raw)
In-Reply-To: <87zjlc6d2b.fsf@secretsauce.net> (Dima Kogan's message of "Thu, 27 Feb 2014 02:54:20 -0800")
Dima Kogan <dima@secretsauce.net> writes:
> Here's a tiny patch to align-regexp. With a prefix argument several
> things are read from the minibuffer using read-input, with one (the
> regex) being much more complicated than the others. It's convenient to
> keep that one in a separate history to make previous entries easily
> selectable.
>
[...]
> +(defvar align-regexp-history nil
> + "Input history for the full user-entered regex in `align-regexp'")
> +
> ;; Sample extension rule set, for vhdl-mode. This should properly be
> ;; in vhdl-mode.el itself.
>
> @@ -946,7 +949,7 @@ construct a rule to pass to `align-region', which does the real work."
> (list (region-beginning) (region-end))
> (if current-prefix-arg
> (list (read-string "Complex align using regexp: "
> - "\\(\\s-*\\)")
> + "\\(\\s-*\\)" 'align-regexp-history)
I think that makes sense. Could you resubmit this patch with an
etc/NEWS entry, and a possible documentation change? I'm not sure
whether we usually mention separate histories for commands or not,
though...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-02-24 3:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 10:54 bug#16891: 24.3; [PATCH] align-regexp now has a separate history for its interactive argument Dima Kogan
2016-02-24 3:05 ` Lars Ingebrigtsen [this message]
2016-02-28 2:49 ` Dima Kogan
2016-02-28 4:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oab6n6z4.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=16891@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.