From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Date: Sun, 28 Feb 2016 17:06:57 +1100 Message-ID: <87oab1tlku.fsf@gnus.org> References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456639705 5213 80.91.229.3 (28 Feb 2016 06:08:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2016 06:08:25 +0000 (UTC) Cc: 5615@debbugs.gnu.org To: IRIE Shinsuke Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 28 07:08:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZuWa-0005eL-FY for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Feb 2016 07:08:12 +0100 Original-Received: from localhost ([::1]:57642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZuWZ-0007To-OV for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Feb 2016 01:08:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZuWV-0007S6-4V for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2016 01:08:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZuWQ-00024Z-5S for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2016 01:08:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZuWQ-00024H-3Q for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2016 01:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aZuWP-0001cp-TU for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2016 01:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Feb 2016 06:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.14566396496205 (code B ref 5615); Sun, 28 Feb 2016 06:08:01 +0000 Original-Received: (at 5615) by debbugs.gnu.org; 28 Feb 2016 06:07:29 +0000 Original-Received: from localhost ([127.0.0.1]:49378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZuVt-0001c1-0N for submit@debbugs.gnu.org; Sun, 28 Feb 2016 01:07:29 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:50779) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZuVr-0001bn-9B for 5615@debbugs.gnu.org; Sun, 28 Feb 2016 01:07:27 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZuVS-0003uI-5E; Sun, 28 Feb 2016 07:07:02 +0100 In-Reply-To: <4BA35102.7050506@yahoo.co.jp> (IRIE Shinsuke's message of "Fri, 19 Mar 2010 19:25:06 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aZuVS-0003uI-5E MailScanner-NULL-Check: 1457244423.09179@8AfS0IvEr5FFavrPrqntbw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114015 Archived-At: IRIE Shinsuke writes: > Sorry, the patch I sent with previous mail is bad, because the previous > patch was made without considering `line-spacing' specified by a > floating point number or frame-parameter. > > So I wrote the new patch. Please check it. [...] Is this still a problem in the current Emacs? > + (defun term-window-height () > + (if (display-graphic-p) > + (let ((e (window-inside-pixel-edges)) > + (s (or (with-current-buffer (window-buffer) line-spacing) > + (frame-parameter nil 'line-spacing) > + 0))) > + (if (floatp s) > + (setq s (truncate (* (frame-char-height) s)))) > + (/ (+ (- (nth 3 e) (cadr e)) s) > + (+ (frame-char-height) s))) > + (window-text-height))) > > (put 'term-mode 'mode-class 'special) [...] > (defun term-check-size (process) > ! (when (or (/= term-height (1- (window-height))) > (/= term-width (term-window-width))) > ! (term-reset-size (1- (window-height)) (term-window-width)) > (set-process-window-size process term-height term-width))) > > (defun term-send-raw-string (chars) > --- 1193,1201 ---- > found)) > > (defun term-check-size (process) > ! (when (or (/= term-height (term-window-height)) > (/= term-width (term-window-width))) > ! (term-reset-size (term-window-height) (term-window-width)) > (set-process-window-size process term-height term-width))) > > (defun term-send-raw-string (chars) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no