From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Considered Harmful 73d213: "Comint, term, and compile new set Emacs" Date: Tue, 05 Apr 2016 12:05:20 +0100 Message-ID: <87oa9otixb.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459854398 31049 80.91.229.3 (5 Apr 2016 11:06:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Apr 2016 11:06:38 +0000 (UTC) Cc: monnier@iro.umontreal.ca, eggert@penguin.cs.ucla.edu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 05 13:06:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1anOoZ-0004nN-Sc for ged-emacs-devel@m.gmane.org; Tue, 05 Apr 2016 13:06:32 +0200 Original-Received: from localhost ([::1]:36220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anOoZ-0004Vi-0g for ged-emacs-devel@m.gmane.org; Tue, 05 Apr 2016 07:06:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anOoL-0004VH-3K for emacs-devel@gnu.org; Tue, 05 Apr 2016 07:06:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anOoH-0006IN-RN for emacs-devel@gnu.org; Tue, 05 Apr 2016 07:06:17 -0400 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:41445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anOoH-0006Hs-LJ for emacs-devel@gnu.org; Tue, 05 Apr 2016 07:06:13 -0400 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1anOoD-0004ao-DX; Tue, 05 Apr 2016 12:06:09 +0100 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1anOoC-0000mX-Mo; Tue, 05 Apr 2016 12:06:08 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202732 Archived-At: I've just found commit 73d213 has been added, which restores the $EMACS behaviour in comint, shell and compile. In other words $EMACS gets set to "t". Unfortunately, this affects both cask and ert-runner which I had altered to take account of and depend on the new behaviour for Emacs-25. In this case, cask and ert-runner use $EMACS to mean "the location of the Emacs to run". This will require explicit setting now. In an truly entertaining piece of irony, my fixes to cask and ert-runner were merged on 23 Mar, the same day as commit 73d213, which breaks the fixes. Not sure how to fix this, but the commentary prior to commit beaab89 says "we are going to rid of this binding, probably in Emacs 23". It seems a shame to be three major versions wrong. Phil