From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Leach Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v5] Add systemd socket launching support Date: Sun, 17 Apr 2016 12:15:07 +0100 Message-ID: <87oa98ebb8.fsf@mattleach.net> References: <871t6do8w1.fsf@mattleach.net> <834mb1dgrg.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1460891735 9437 80.91.229.3 (17 Apr 2016 11:15:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Apr 2016 11:15:35 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 17 13:15:22 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1arkfh-0007wr-N2 for ged-emacs-devel@m.gmane.org; Sun, 17 Apr 2016 13:15:21 +0200 Original-Received: from localhost ([::1]:44501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arkfg-0000wI-QK for ged-emacs-devel@m.gmane.org; Sun, 17 Apr 2016 07:15:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arkfd-0000lX-1U for emacs-devel@gnu.org; Sun, 17 Apr 2016 07:15:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arkfb-0002KV-Ub for emacs-devel@gnu.org; Sun, 17 Apr 2016 07:15:16 -0400 Original-Received: from mx0.mattleach.net ([176.58.118.143]:32976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arkfW-0002K6-L0; Sun, 17 Apr 2016 07:15:10 -0400 Original-Received: by mx0.mattleach.net (Postfix, from userid 99) id C48AD6222F; Sun, 17 Apr 2016 12:15:09 +0100 (BST) Original-Received: from spline.mattleach.net (host81-159-147-176.range81-159.btcentralplus.com [81.159.147.176]) by mx0.mattleach.net (Postfix) with ESMTPSA id B05EF6222A; Sun, 17 Apr 2016 12:15:02 +0100 (BST) In-Reply-To: <834mb1dgrg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Apr 2016 12:50:27 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 176.58.118.143 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203006 Archived-At: --=-=-= Content-Type: text/plain Hi Eli, Thanks for taking another look at this. Eli Zaretskii writes: >> From: Matthew Leach >> Cc: Eli Zaretskii , Stefan Monnier >> Date: Sun, 10 Apr 2016 15:06:54 +0100 >> >> Here is a new version of the systemd integration & socket-launching >> patches. The main change in this series is providing an interface for >> other socket-launching applications to be integrated, namely >> `set_external_socket_descriptor' in process.c. >> >> Feedback & comments welcome! > > Thanks, I pushed it to the master branch. > > I think it would make sense to add this feature to the list in > EMACS_CONFIG_FEATURES (see the configure script for how we generate > that list). Ah I didn't know about that list. Please see the attached patch which should fix that. > A few minor comments, for the future: > > . Be consistent in how you quote symbols in the log entries. In this > submission, you sometimes quoted `like this', sometimes 'like > this', and sometimes left the symbols unquoted. Pick one style and > stick to it. > > . The way to call out a function name is 'function' (with quotes). > The GNU Coding Standards frown upon using function(), which looks > like a call to the function with no arguments, not what you mean. Thank you for the feedback. -- Matt --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-libsystemd-to-EMACS_CONFIG_FEATURES.patch >From 39b077d3f3cb84867ef4a177654c53e5ca8f604c Mon Sep 17 00:00:00 2001 From: Matthew Leach Date: Sun, 17 Apr 2016 12:07:19 +0100 Subject: [PATCH] Add libsystemd to EMACS_CONFIG_FEATURES * configure.ac: Add LIBSYSTEMD to EMACS_CONFIG_FEATURES and print a message at the end of configure stating whether Emacs will be build with libsystemd support. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 54e9ec5..86b16b6 100644 --- a/configure.ac +++ b/configure.ac @@ -5200,7 +5200,7 @@ emacs_config_features= for opt in XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS \ GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT \ LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS X_TOOLKIT X11 NS MODULES \ - XWIDGETS; do + XWIDGETS LIBSYSTEMD; do case $opt in NOTIFY|ACL) eval val=\${${opt}_SUMMARY} ;; @@ -5247,6 +5247,7 @@ AS_ECHO([" Does Emacs use -lXaw3d? ${HAVE_XAW3D Does Emacs use -lm17n-flt? ${HAVE_M17N_FLT} Does Emacs use -lotf? ${HAVE_LIBOTF} Does Emacs use -lxft? ${HAVE_XFT} + Does Emacs use -lsystemd? ${HAVE_LIBSYSTEMD} Does Emacs directly use zlib? ${HAVE_ZLIB} Does Emacs have dynamic modules support? ${HAVE_MODULES} Does Emacs use toolkit scroll bars? ${USE_TOOLKIT_SCROLL_BARS} -- 2.8.0 --=-=-=--