From: Matthew Leach <matthew@mattleach.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: [PATCH v5] Add systemd socket launching support
Date: Sun, 17 Apr 2016 12:15:07 +0100 [thread overview]
Message-ID: <87oa98ebb8.fsf@mattleach.net> (raw)
In-Reply-To: <834mb1dgrg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Apr 2016 12:50:27 +0300")
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
Hi Eli,
Thanks for taking another look at this.
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Matthew Leach <matthew@mattleach.net>
>> Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA>
>> Date: Sun, 10 Apr 2016 15:06:54 +0100
>>
>> Here is a new version of the systemd integration & socket-launching
>> patches. The main change in this series is providing an interface for
>> other socket-launching applications to be integrated, namely
>> `set_external_socket_descriptor' in process.c.
>>
>> Feedback & comments welcome!
>
> Thanks, I pushed it to the master branch.
>
> I think it would make sense to add this feature to the list in
> EMACS_CONFIG_FEATURES (see the configure script for how we generate
> that list).
Ah I didn't know about that list. Please see the attached patch which
should fix that.
> A few minor comments, for the future:
>
> . Be consistent in how you quote symbols in the log entries. In this
> submission, you sometimes quoted `like this', sometimes 'like
> this', and sometimes left the symbols unquoted. Pick one style and
> stick to it.
>
> . The way to call out a function name is 'function' (with quotes).
> The GNU Coding Standards frown upon using function(), which looks
> like a call to the function with no arguments, not what you mean.
Thank you for the feedback.
--
Matt
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-libsystemd-to-EMACS_CONFIG_FEATURES.patch --]
[-- Type: text/x-diff, Size: 1586 bytes --]
From 39b077d3f3cb84867ef4a177654c53e5ca8f604c Mon Sep 17 00:00:00 2001
From: Matthew Leach <matthew@mattleach.net>
Date: Sun, 17 Apr 2016 12:07:19 +0100
Subject: [PATCH] Add libsystemd to EMACS_CONFIG_FEATURES
* configure.ac: Add LIBSYSTEMD to EMACS_CONFIG_FEATURES and print a
message at the end of configure stating whether Emacs will be build
with libsystemd support.
---
configure.ac | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 54e9ec5..86b16b6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5200,7 +5200,7 @@ emacs_config_features=
for opt in XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS \
GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT \
LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS X_TOOLKIT X11 NS MODULES \
- XWIDGETS; do
+ XWIDGETS LIBSYSTEMD; do
case $opt in
NOTIFY|ACL) eval val=\${${opt}_SUMMARY} ;;
@@ -5247,6 +5247,7 @@ AS_ECHO([" Does Emacs use -lXaw3d? ${HAVE_XAW3D
Does Emacs use -lm17n-flt? ${HAVE_M17N_FLT}
Does Emacs use -lotf? ${HAVE_LIBOTF}
Does Emacs use -lxft? ${HAVE_XFT}
+ Does Emacs use -lsystemd? ${HAVE_LIBSYSTEMD}
Does Emacs directly use zlib? ${HAVE_ZLIB}
Does Emacs have dynamic modules support? ${HAVE_MODULES}
Does Emacs use toolkit scroll bars? ${USE_TOOLKIT_SCROLL_BARS}
--
2.8.0
next prev parent reply other threads:[~2016-04-17 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 14:06 [PATCH v5] Add systemd socket launching support Matthew Leach
2016-04-14 17:54 ` Matthew Leach
2016-04-17 5:42 ` Paul Eggert
2016-04-17 11:30 ` Matthew Leach
2016-04-18 5:44 ` Paul Eggert
2016-04-18 19:33 ` Matthew Leach
2016-04-21 20:59 ` Matthew Leach
2016-04-26 9:17 ` Matthew Leach
2016-04-26 16:15 ` Paul Eggert
2016-04-27 9:56 ` Matthew Leach
2016-04-16 9:50 ` Eli Zaretskii
2016-04-17 11:15 ` Matthew Leach [this message]
2016-04-21 16:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa98ebb8.fsf@mattleach.net \
--to=matthew@mattleach.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.